Repository navigation
refactor(authz): display team members information agregated in the table - #222
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 98.53% 98.70% +0.17%
==========================================
Files 73 80 +7
Lines 1299 1393 +94
Branches 426 465 +39
==========================================
+ Hits 1280 1375 +95
+ Misses 19 18 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7bd0f3f to
3a36374
Compare
2c4b5ab to
2d4a009
Compare
2d4a009 to
339d753
Compare
339d753 to
f4da7f4
Compare
2999fb6 to
f429709
Compare
f429709 to
17870cb
Compare
|
@jacobo-dominguez-wgu @jesusbalderramawgu @bra-i-am friendly reminder for review help |
| // An aggregate scope covers every course/library across the platform or within one org, | ||
| // so it names no single resource and the API sends an empty display name for it. |
There was a problem hiding this comment.
| // An aggregate scope covers every course/library across the platform or within one org, | |
| // so it names no single resource and the API sends an empty display name for it. |
| scopeIcon = RESOURCE_ICONS.GLOBAL; | ||
| scopeText = formatMessage(componentMessages['authz.user.table.org.all.organizations.label']); | ||
| } else if (aggregateType === 'org') { | ||
| scopeIcon = Business; |
There was a problem hiding this comment.
Thanks for point this out, I will update it. The Figma was updated yesterday so I was not aware of the new icon.
b9be295 to
c80f54d
Compare
c80f54d to
a07b312
Compare
carlos-marquez-wgu
left a comment
There was a problem hiding this comment.
I went through all test instructions and compared against the figma, everything works and looks great, thanks, @dcoa !
nit: I just noticed a couple things
In the new figma, this pagination dropdown was moved from the right side to the center
Not sure if this a known trade off or is just fine, but I noticed columns width change between pages
|
thanks @carlos-marquez-wgu I will merge this PR as it is, because it is large enough. I will review the columns resize in a following PR and I will comment the footer change in one of the issues created as Enhancements to represent the changes implemented in the design this week. |
|
Hi @dcoa! Thanks for the PR. I tested it, and it works great! I just have two comments:
|
|
🎉 This PR is included in version 1.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |







Context
The Team Members tab renders one row per role assignment. The new design regroups it into one row per user, with that user's assignments nested underneath an expandable row.
Important
It follows the API contract defined in openedx-authz. It needs the backend implementation here openedx/openedx-authz#451
Changes summary
Data
GET /api/authz/v1/users/instead of/assignments/.TeamMemberandTeamMemberAssignmenttypes that match the API.Team Members table
useExclusiveRowExpansionhook.mdup (the table scrolls on small screens), the breakdown header matches the Roles & Permissions category rows, and icons use the primary color.Shared
ViewMoreLinkis now a button instead of a link. Making the action accessible.getAggregateScopeTypeandgetScopeContextTypedetect org-wide and platform-wide scopes.Errors & permissions
role="status"and a label).Testing instructions
course-v1:MyOrg+*)course-v1:*orlib:*)In Team Members tab
"+N more roles".Clicking it opens the role breakdown, and only one breakdown can be open at a time."Showing X of Y"."View all roles"appears when not all roles are listed, and opens the user's page."All courses" / "All libraries"in the breakdown."All platform"with a globe icon in the row and in the breakdown's Organization column."Showing N users of M."count updates.In User audit page
7. Org-wide and platform-wide roles show "All courses" / "All libraries" and "All platform".
Edge cases
8. A user with no team view permission sees the 403 Access Denied page.
Additional information
Closes openedx/openedx-authz#407
Closes #174
Address #156
Supported by claude