feat(pathways): implement CatalogPathway - #819
Agrendalath wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @Agrendalath! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
643644c to
fa1d75b
Compare
bradenmacdonald
left a comment
There was a problem hiding this comment.
Looks good! I read the code but did not test it.
We should probably wait until #818 is finalized and merged before merging this, unless that's blocking you.
| name = case_insensitive_char_field( | ||
| max_length=255, | ||
| blank=False, | ||
| help_text=_('The learner-facing name of this category, e.g. "Master\'s Degree". Operators may change this.'), | ||
| ) |
There was a problem hiding this comment.
Do you think this will need to be translatable in the future?
Individual courses/pathways usually have titles and content in one specific language, but I can imagine that Pathway Categories like "Master's Degree" may contain pathways of various languages and operators may want to be able to translate the name like "Master's Degree" into the user's language.
|
|
||
| class PathwayEnrollment(models.Model): | ||
| """ | ||
| Ties a learner to a `CatalogPathway`. |
There was a problem hiding this comment.
So there are no enrollment modes for pathways, right? (Like honor vs. verified for courses)
This introduces:
TheCatalogPathway - Pathwayrelations are based on #818, so it makes sense to merge that PR first.I reverted the direction change, as decided in #818 (comment).