8373348: Cache AdapterHandleEntry::_sig_cc field in AOTCache - #32219
8373348: Cache AdapterHandleEntry::_sig_cc field in AOTCache#32219matias9927 wants to merge 2 commits into
Conversation
|
👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@matias9927 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
|
@ashu-mehra please look. |
| } | ||
| JRT_END | ||
|
|
||
| void SigEntry::metaspace_pointers_do(MetaspaceClosure* it) { |
There was a problem hiding this comment.
Any reason for adding this method here instead of signature.cpp which has other SigEntry methods?
Signature calling conventions are regenerated at runtime as they were not being archived, so this patch now archives them and removes the regeneration code. Verified with tier 1-5 tests.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32219/head:pull/32219$ git checkout pull/32219Update a local copy of the PR:
$ git checkout pull/32219$ git pull https://git.openjdk.org/jdk.git pull/32219/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32219View PR using the GUI difftool:
$ git pr show -t 32219Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32219.diff
Using Webrev
Link to Webrev Comment