Skip to content

8373348: Cache AdapterHandleEntry::_sig_cc field in AOTCache - #32219

Open
matias9927 wants to merge 2 commits into
openjdk:masterfrom
matias9927:sig_cc_8373348
Open

8373348: Cache AdapterHandleEntry::_sig_cc field in AOTCache#32219
matias9927 wants to merge 2 commits into
openjdk:masterfrom
matias9927:sig_cc_8373348

Conversation

@matias9927

@matias9927 matias9927 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Signature calling conventions are regenerated at runtime as they were not being archived, so this patch now archives them and removes the regeneration code. Verified with tier 1-5 tests.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8373348: Cache AdapterHandleEntry::_sig_cc field in AOTCache (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32219/head:pull/32219
$ git checkout pull/32219

Update a local copy of the PR:
$ git checkout pull/32219
$ git pull https://git.openjdk.org/jdk.git pull/32219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32219

View PR using the GUI difftool:
$ git pr show -t 32219

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32219.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 5, 2026

Copy link
Copy Markdown

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot hotspot-dev@openjdk.org label Aug 5, 2026
@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

@matias9927 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

@matias9927
matias9927 marked this pull request as ready for review August 5, 2026 18:11
@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 5, 2026
@mlbridge

mlbridge Bot commented Aug 5, 2026

Copy link
Copy Markdown

Webrevs

@vnkozlov

vnkozlov commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@ashu-mehra please look.

}
JRT_END

void SigEntry::metaspace_pointers_do(MetaspaceClosure* it) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for adding this method here instead of signature.cpp which has other SigEntry methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants