Skip to content

8389860: Remove CDS "optimized module handling" optimization - #32228

Open
iklam wants to merge 2 commits into
openjdk:masterfrom
iklam:8389860-remove-cds-optimized-module-handling
Open

8389860: Remove CDS "optimized module handling" optimization#32228
iklam wants to merge 2 commits into
openjdk:masterfrom
iklam:8389860-remove-cds-optimized-module-handling

Conversation

@iklam

@iklam iklam commented Aug 6, 2026

Copy link
Copy Markdown
Member

This PR removes the "optimized module handling" optimization, which provides only a small benefit in uncommon cases for traditional CDS. It is not applicable for the new AOT workflow.

Please see the JBS issue for details.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8389860: Remove CDS "optimized module handling" optimization (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32228/head:pull/32228
$ git checkout pull/32228

Update a local copy of the PR:
$ git checkout pull/32228
$ git pull https://git.openjdk.org/jdk.git pull/32228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32228

View PR using the GUI difftool:
$ git pr show -t 32228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32228.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 6, 2026

Copy link
Copy Markdown

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 6, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot hotspot-dev@openjdk.org label Aug 6, 2026
@openjdk

openjdk Bot commented Aug 6, 2026

Copy link
Copy Markdown

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Aug 6, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 6, 2026
@mlbridge

mlbridge Bot commented Aug 6, 2026

Copy link
Copy Markdown

Webrevs

@vnkozlov vnkozlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup.

@vnkozlov

vnkozlov commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Looks like this change broke ARM build as GHA shows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants