8348872: jabswitch.cpp: regEnable and regDeleteValue leak reallocated data buffer

[MBaesken]

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8348872: jabswitch.cpp: regEnable and regDeleteValue leak reallocated data buffer (Bug - P3)

Reviewers

• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32236/head:pull/32236
$ git checkout pull/32236

Update a local copy of the PR:
$ git checkout pull/32236
$ git pull https://git.openjdk.org/jdk.git pull/32236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32236

View PR using the GUI difftool:
$ git pr show -t 32236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32236.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: client. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (3450aa40)

[MBaesken]

linux-x64-hs-minimal / build - Build / test - seems to have an infrastructure issue 'Failed to resolve action download info. Error: Service Unavailable' - most likely unrelated.

[prrace]

This looks OK to me but I want @azuev-java to review (and test) it.

[prrace]

It seems unlikely that windows takes ownership of this memory, so we should free it.
However given that jabswitch is very emphemeral as an app, leaks are not a big deal.

[MBaesken]

Lots of 'Failed to resolve action download info. Error: Service Unavailable' in the GHAs, seem to be unrelated .

[MBaesken]

This looks OK to me but I want @azuev-java to review (and test) it.

Hi Phil, thanks for the review !
I added a number of RegCloseKey calls too, to avoid handle leaks (should not be that bad for a short lived application like jabswitch, but still better to do imho).

Btw. speaking of missing RegCloseKey after RegOpenKeyEx/RegOpenKeyExA, should we add here

jdk/src/java.desktop/windows/native/libawt/windows/awt_Font.cpp

Line 1775 in 7327d05

LONG lRet = ::RegOpenKeyExA(hRootKey, lpszSubKey, 0, KEY_ALL_ACCESS, &hKey);

too the RegCloseKey calls ?