8389905: Shenandoah: SBSA::card_table uses own temp registers that clobber obj

[earthling-amzn]

Use temporary registers provided by caller for card barrier, rather than relying on global scratch registers.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8389905: Shenandoah: SBSA::card_table uses own temp registers that clobber obj (Bug - P2)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Kelvin Nilsen (@kdnilsen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32246/head:pull/32246
$ git checkout pull/32246

Update a local copy of the PR:
$ git checkout pull/32246
$ git pull https://git.openjdk.org/jdk.git pull/32246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32246

View PR using the GUI difftool:
$ git pr show -t 32246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32246.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8389905: Shenandoah: SBSA::card_table uses own temp registers that clobber obj

Reviewed-by: shade, kdnilsen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 30835f1: 8388948: Javac crashes with NullPointerException in Types.intersect during method type inference of complex overlapping intersection bounds
• a111b32: 8389554: ARM32: Unbreak non-preview mode after JEP 401 integration
• 433cfb9: 8388169: Test gc/g1/TestCodeCacheUnloadDuringConcurrentMark.java failed: Expected a not-entrant target nmethod before concurrent mark
• ... and 12 more: https://git.openjdk.org/jdk/compare/fd788394fec88cc163a687e5cb4f371425ac8011...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

[shipilev]

Looks good! I have checked with my local script that RISC-V builds and runs Shenandoah fine.

[mlbridge]

Webrevs

• 00: Full (a3a6f9fd)

[kdnilsen]

Thanks for cleaning this up.