Add SCOT to multimodal data integration - #357
Closed
scottgigante-immunai wants to merge 4 commits into
Closed
Conversation
This reverts commit d72be16.
Collaborator
Author
|
@atong01 the unbalanced SCOT method you merged a while back was never imported and therefore never tested. When we import it, it fails tests due to an overflow error returning the aligned space as all NaN. Would you prefer to a) figure out how to fix it or b) remove it? |
Contributor
|
I'm probably not going to fix it in the near future. I'd recommend removing it until someone has time. The original repo seems to be updated with some "v2.0" since I last looked. Not sure what is changed in this version. I had to fork and make it installable at some point which is what we are currently using. Thanks for your help Scott! |
Merged
This reverts commit a35142d.
Contributor
|
This pull request has been automatically closed because it has not had recent activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission type
Testing
Submission guidelines
PR review checklist
This PR will be evaluated on the basis of the following checks:
__init__.pyand were tested in the pipeline