Add dimred task/datasets descriptions - #490
Conversation
|
This is a draft because I still need to add something for the Nestorowa 2016 dataset. The current description says this is human data but the only paper with this name I could find is https://doi.org/10.1182/blood-2016-05-716480 which is mouse. @mvinyard I think you added this originally, do you know what is correct? Also, it would be great to have a way to add a DOI for each dataset. Trying to find papers just from the year and name is a pain. Also also, should these descriptions go in the main dataset files rather than the task-specific file (to avoid having to duplicate stuff/having slightly different info)? |
|
At the moment we only have decorators in the task-specific dataset functions. But it's a good point that this could go into the data loaders. I'm not sure what the considerations are there w.r.t. where the decorator function is run (in which image). And how easily we can then use the text in the task outputs. |
I don't think this should programmatically go into the dataset loaders, since e.g. A good start would be to follow the dataset loader name template in CONTRIBUTING:
|
I believe that's correct, @lazappi - let me know how I can help- thanks! |
|
That DOI is the correct reference (so this is actually mouse data)? |
|
Yes, I think that's right. FYI I have an open PR to include a DOI/reference for all dataset loaders so this doesn't happen again: #500 |
|
You are correct, @lazappi. This is mouse data. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #490 +/- ##
==========================================
+ Coverage 94.04% 94.08% +0.04%
==========================================
Files 113 114 +1
Lines 2906 2927 +21
Branches 150 150
==========================================
+ Hits 2733 2754 +21
Misses 118 118
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@LuckyMD are you happy to approve this? |
Submission type
Testing
Submission guidelines
PR review checklist
This PR will be evaluated on the basis of the following checks:
__init__.pyand were tested in the pipeline