Skip to content

retry failed request - #668

Merged
scottgigante-immunai merged 3 commits into
openproblems-bio:mainfrom
scottgigante-immunai:bugfix/tabula_muris_senis/retry
Nov 2, 2022
Merged

retry failed request#668
scottgigante-immunai merged 3 commits into
openproblems-bio:mainfrom
scottgigante-immunai:bugfix/tabula_muris_senis/retry

Conversation

@scottgigante-immunai

Copy link
Copy Markdown
Collaborator

Requests is a little flaky. This should fix it.

@mxposed

mxposed commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator

Looks good! Do you want to change another requests call in load_raw_counts too?

@codecov

codecov Bot commented Nov 2, 2022

Copy link
Copy Markdown

Codecov Report

Base: 94.96% // Head: 94.96% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7c83c3f) compared to base (2a1c8fb).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7c83c3f differs from pull request most recent head 48e83df. Consider uploading reports for the commit 48e83df to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         153      153           
  Lines        3891     3894    +3     
  Branches      201      201           
=======================================
+ Hits         3695     3698    +3     
  Misses        128      128           
  Partials       68       68           
Flag Coverage Δ
unittests 94.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openproblems/data/tabula_muris_senis.py 83.11% <100.00%> (+0.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scottgigante-immunai
scottgigante-immunai merged commit 69c8f5d into openproblems-bio:main Nov 2, 2022
@scottgigante-immunai
scottgigante-immunai deleted the bugfix/tabula_muris_senis/retry branch November 2, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants