Add method and metric descriptions - #810
Merged
scottgigante-immunai merged 3 commits intoFeb 28, 2023
Merged
Conversation
Contributor
|
|
scottgigante-immunai
force-pushed
the
docs/metric_descriptions
branch
from
February 2, 2023 19:18
c42e8d4 to
13fc168
Compare
Member
|
What needs to be done before we can merge this pr? :) |
Collaborator
Author
|
Pending methods descriptions from @danielStrobl @giovp @wes-lewis in the supplementary information doc. Once those are in, this can be merged. |
Collaborator
|
@scottgigante-immunai @LuckyMD think all should be done from my side? let me know if anything else is needed. |
Closed
Collaborator
Author
|
@giovp I'm only missing NMF from you. @danielStrobl and @mxposed still waiting on your method descriptions. |
Collaborator
|
@scottgigante-immunai added vanilla nmf |
scottgigante-immunai
force-pushed
the
docs/metric_descriptions
branch
from
February 27, 2023 16:23
4cd341b to
7036d37
Compare
scottgigante-immunai
force-pushed
the
docs/metric_descriptions
branch
from
February 27, 2023 16:25
7036d37 to
06dd356
Compare
scottgigante-immunai
marked this pull request as ready for review
February 27, 2023 16:25
rcannood
approved these changes
Feb 28, 2023
rcannood
left a comment
Member
There was a problem hiding this comment.
Just one minor change requested. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.