feat: OpenShift Virtualization Higher Density by fabiand · Pull Request #1630 · openshift/enhancements

fabiand · 2024-05-27T13:01:29Z

A feature describing CNV's path to higher density based on

phase 1: wasp
phase 2: kube swap

fabiand · 2024-05-27T13:02:03Z

cc @enp0s3 @iholder101

enp0s3

@fabiand Thank you!

iholder101

Thank you @fabiand!

fabiand · 2024-06-03T08:28:17Z

@enp0s3 @iholder101 many thanks for your inputs! I've addressed them and resolved consversations.
Please reopen conversations if you disagree.

openshift-ci · 2024-06-03T08:29:13Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fabiand · 2024-06-12T12:38:22Z

@fabiand: all tests passed!

Thank you so much.

enp0s3

@fabiand Hi, did second round, have some few cooments/ideas

A feature describing CNV's path to higher density based on - phase 1: wasp - phase 2: kube swap Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

fabiand · 2024-06-26T08:40:32Z

All set.

openshift-ci · 2024-06-26T08:58:21Z

@fabiand: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

iholder101 · 2024-07-01T13:13:32Z

Looks great to me!
/lgtm

openshift-ci · 2024-07-01T13:14:49Z

@iholder101: changing LGTM is restricted to collaborators

Details

In response to this:

Looks great to me!
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2024-07-30T01:15:38Z

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

enp0s3 · 2024-07-30T04:24:14Z

/remove-lifecycle stale

enp0s3 · 2024-07-30T04:24:27Z

/lgtm

fabiand · 2024-08-13T08:40:57Z

@mrunalp can we get this merged or reviewed?

openshift-bot · 2024-09-10T09:15:48Z

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

fabiand · 2024-09-10T09:19:45Z

/remove-lifecycle stale

…

Message ID: ***@***.***>

iholder101 · 2024-09-10T15:30:46Z

/hold

We need to update the GA section w.r.t. our plan forward to restrict non-CNV users from accessing swap.
I will take ownership on the PR to do so. Will introduce a replacement PR very soon.

iholder101 · 2024-09-17T11:03:47Z

See this replacement PR: #1679.
This PR can be closed now.

/close

openshift-ci · 2024-09-17T11:03:56Z

@iholder101: You can't close an active issue/PR unless you authored it or you are a collaborator.

Details

In response to this:

See this replacement PR: #1679.
This PR can be closed now.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2024-10-16T01:15:16Z

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2024-10-23T08:45:51Z

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

enp0s3 · 2024-10-23T15:17:11Z

@fabiand Hi, I think only you have the permission to close this PR

openshift-bot · 2024-10-31T00:15:17Z

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2024-10-31T00:15:28Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot requested review from cybertron and runcom May 27, 2024 13:02

enp0s3 reviewed Jun 1, 2024

View reviewed changes

Comment thread enhancements/kubelet/virtualization-higher-workload-density.md Outdated

Comment thread enhancements/kubelet/virtualization-higher-workload-density.md Outdated

iholder101 reviewed Jun 2, 2024

View reviewed changes

fabiand force-pushed the cnv-swap branch from 9abac9a to bf98aae Compare June 12, 2024 08:19

enp0s3 reviewed Jun 13, 2024

View reviewed changes

Barakmor1 reviewed Jun 13, 2024

View reviewed changes

Comment thread enhancements/kubelet/virtualization-higher-workload-density.md Outdated

Barakmor1 reviewed Jun 13, 2024

View reviewed changes

Comment thread enhancements/kubelet/virtualization-higher-workload-density.md

iholder101 reviewed Jun 19, 2024

View reviewed changes

Comment thread enhancements/kubelet/virtualization-higher-workload-density.md

fabiand added 14 commits June 26, 2024 10:40

feat: OpenShift Virtualization Higher Density

87ce6f4

A feature describing CNV's path to higher density based on - phase 1: wasp - phase 2: kube swap Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv: Swap add more design details

64eb060

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv: Drop all xml style comments to make the md linter happy

16bbc80

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv: Address Igor's comments

f0af1f7

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv: Address Itamar's comments

474c5d7

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv: Add line breaks

13610ce

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv: fix headers

7bdd858

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv: Fix table header

e59182d

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv: Mention KSM and FPR

68a8501

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv: Add section to make linter happy

68617c6

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv,swap Fix metadata

4de46f8

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv,swap: Clarification of VM vs infra overhead

0add279

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv,swap: Address more review comments

882a814

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

cnv,swap: Addressed more comments

f87092a

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>

fabiand force-pushed the cnv-swap branch from c74969f to f87092a Compare June 26, 2024 08:40

fabiand mentioned this pull request Jun 26, 2024

CNV enhancements #1650

Closed

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2024

openshift-ci Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2024

openshift-ci Bot assigned enp0s3 Jul 30, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2024

openshift-ci Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2024

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024

iholder101 mentioned this pull request Sep 17, 2024

Feature: OpenShift Virtualization Higher Density #1679

Closed

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2024

openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 23, 2024

openshift-ci Bot closed this Oct 31, 2024

Conversation

fabiand commented May 27, 2024

Uh oh!

fabiand commented May 27, 2024

Uh oh!

enp0s3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

iholder101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabiand commented Jun 3, 2024

Uh oh!

openshift-ci Bot commented Jun 3, 2024

Uh oh!

fabiand commented Jun 12, 2024

Uh oh!

enp0s3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabiand commented Jun 26, 2024

Uh oh!

openshift-ci Bot commented Jun 26, 2024

Uh oh!

iholder101 commented Jul 1, 2024

Uh oh!

openshift-ci Bot commented Jul 1, 2024

Uh oh!

openshift-bot commented Jul 30, 2024

Uh oh!

enp0s3 commented Jul 30, 2024

Uh oh!

enp0s3 commented Jul 30, 2024

Uh oh!

fabiand commented Aug 13, 2024

Uh oh!

openshift-bot commented Sep 10, 2024

Uh oh!

fabiand commented Sep 10, 2024 via email

Uh oh!

iholder101 commented Sep 10, 2024

Uh oh!

iholder101 commented Sep 17, 2024

Uh oh!

openshift-ci Bot commented Sep 17, 2024

Uh oh!

openshift-bot commented Oct 16, 2024

Uh oh!

openshift-bot commented Oct 23, 2024

Uh oh!

enp0s3 commented Oct 23, 2024

Uh oh!

openshift-bot commented Oct 31, 2024

Uh oh!

openshift-ci Bot commented Oct 31, 2024