Skip to content

OCPBUGS-104190: Use patched x/net fork v0.50.0-sec.4 - #197

Open
prabhapa wants to merge 1 commit into
openshift:release-4.21from
prabhapa:cve/4.21/OCPBUGS-104190
Open

prabhapa wants to merge 1 commit into
openshift:release-4.21from
prabhapa:cve/4.21/OCPBUGS-104190

Conversation

@prabhapa

Copy link
Copy Markdown

Summary

This PR replaces golang.org/x/net with github.com/openshift-sustaining/net@v0.50.0-sec.4.

Rationale

CVE-2026-33814, a Go HTTP/2 denial of service caused by a malformed SETTINGS_MAX_FRAME_SIZE frame, is fixed upstream in golang.org/x/net v0.53.0, which requires Go 1.25. The release-4.21 branch is built with Go 1.24 and cannot consume that upstream release. The v0.50.0-sec.4 sustaining fork carries the compatible backport for this Go version.

Source

Jira coverage

This shared source change addresses:

  • OCPBUGS-104190 — openshift4/ose-prometheus-node-exporter-rhel9

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 24, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@prabhapa: This pull request references Jira Issue OCPBUGS-104190, which is invalid:

  • expected dependent Jira Issue OCPBUGS-102026 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR replaces golang.org/x/net with github.com/openshift-sustaining/net@v0.50.0-sec.4.

Rationale

CVE-2026-33814, a Go HTTP/2 denial of service caused by a malformed SETTINGS_MAX_FRAME_SIZE frame, is fixed upstream in golang.org/x/net v0.53.0, which requires Go 1.25. The release-4.21 branch is built with Go 1.24 and cannot consume that upstream release. The v0.50.0-sec.4 sustaining fork carries the compatible backport for this Go version.

Source

Jira coverage

This shared source change addresses:

  • OCPBUGS-104190 — openshift4/ose-prometheus-node-exporter-rhel9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@redhat-chai-bot

Copy link
Copy Markdown

/test ginkgo-tests-cmo

Automated triage: Retesting to gather additional signal.

Job classification: Eligible long-running Azure IPI integration/e2e presubmit job; definition uses the ipi-azure workflow with cluster provisioning and post-run teardown. The ginkgo-tests-cmo test phase was not reached.
Revision check: incoming SHA fb538e140bd0e9be59e77be4c6a95bdb56caede5; Prow run SHA fb538e140bd0e9be59e77be4c6a95bdb56caede5; current PR HEAD fb538e140bd0e9be59e77be4c6a95bdb56caede5; match.
Execution status: Tests did not execute. The run failed in the pre-execution ipi-conf-azure step while oc adm release info could not retrieve a release-image blob from the build04 registry's Cloudflare R2 backend: dial tcp [2606:4700:113::1]:443: connect: network is unreachable. The Prow run lasted about 40 minutes, but the cluster was not installed and the test phase did not start. <https://prow.ci.openshift.org/view/gs/test-platform-results-public/pr-logs/pull/openshift_node_exporter/197/pull-ci-openshift-node_exporter-release-4.21-ginkgo-tests-cmo/2102998359601057792|Prow run>
Completed supporting jobs: ci/prow/images, ci/prow/okd-scos-images, ci/prow/test-unit, ci/prow/vendor, and ci/prow/verify-deps succeeded. Pending: ci/prow/e2e-agnostic-cmo, ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade, and tide. No completed supporting e2e job; pending jobs do not count as positive signal.
Fleet-wide failure rate: Exact job 14/20 successful across the analyzed history (70%); release-4.21 has 0/1 successful run. Test pass rates are not applicable because no tests executed.
Open regressions: Not applicable — no failing test was reached.
Linked bugs: Not applicable — no failing test was reached.
Overlap assessment: The PR changes the golang.org/x/net dependency to a sustaining fork and updates vendored dependency code. The observed failure is in CI's pre-test release-image retrieval over the build04 registry/R2 network path, before the node_exporter image could affect the tested cluster. No direct or indirect overlap with the failure mechanism was found.
Missing-coverage risk: Uncertain because this run provided no e2e signal and it is the only completed e2e job; the other e2e checks were still pending. A fresh run is needed to execute the coverage before any override consideration.
Prior bot activity on this SHA: None; no prior retest or override for this job on this SHA.
Decision and action: Targeted retest. The early/no-test-execution override gates are not fully satisfied because there is no completed supporting e2e signal. If this job fails again, the bot will not retest it on this commit.


AI-generated. Review for accuracy.

@simonpasquier

Copy link
Copy Markdown

/approve
/label backport-risk-assessed
/verified by @simonpasquier

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 25, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@simonpasquier: This PR has been marked as verified by @simonpasquier.

Details

In response to this:

/approve
/label backport-risk-assessed
/verified by @simonpasquier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2026
@tonyxrmdavidson

Copy link
Copy Markdown

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown

Scheduling required tests:
/test e2e-agnostic-cmo
/test e2e-aws
/test e2e-aws-upgrade

@simonpasquier

Copy link
Copy Markdown

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@simonpasquier: This pull request references Jira Issue OCPBUGS-104190, which is invalid:

  • expected dependent Jira Issue OCPBUGS-102026 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@simonpasquier

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2026
@openshift-ci

openshift-ci Bot commented Oct 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prabhapa, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier

Copy link
Copy Markdown

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@simonpasquier: This pull request references Jira Issue OCPBUGS-104190, which is invalid:

  • expected dependent Jira Issue OCPBUGS-102026 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@simonpasquier

Copy link
Copy Markdown

/test ginkgo-tests-cmo

@openshift-ci

openshift-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown

@prabhapa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants