This repository was archived by the owner on Feb 29, 2024. It is now read-only.
Update default.rb - #4
Closed
kristvanbesien wants to merge 1 commit into
Closed
Conversation
In ruby the "truth" value of a set variable is always true, so we need to explicitly compare with :true
|
Thank you for contributing to openstack/puppet-pacemaker! openstack/puppet-pacemaker uses Gerrit for code review. If you have never contributed to OpenStack before make sure you have read the Otherwise please visit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the value of @resource[:master_slave] is either :true or :false, and symbols in Ruby are always truthy, this needs to be compared explicitly with the symbol :true.
This is actually the same fix as in the following pull request:
redhat-openstack/puppet-pacemaker#66
This was closed, because the project was moved from redhat-openstack to openstack, with the suggestion to resubmit the fix to the new location. However this was never done by the original author of the fix.
Hence I am submitting this fix myself.