Conversation
Implement backup, restore, rotate-dek, confirm-rotate-dek, and metrics subcommands for keystone-manage storage, completing CLI coverage for all Raft cluster operations defined in ADR 0016-v2. - Add Backup/Restore RPCs to ClusterAdminService (proto + server handlers): server-streaming Backup chunks the encrypted snapshot at 256 KiB; client-streaming Restore accumulates chunks and calls install_full_snapshot - Expose FjallStateMachine::snapshot_dir() and decode_backup_blob() for use by the restore handler (validates AES-256-GCM envelope, returns OpenRaft Snapshot ready for install_full_snapshot) - Wire sm: Arc<StateMachineStore> into ClusterAdminServiceImpl so the backup handler can call build_snapshot() and read the resulting encrypted file - New CLI commands: backup (--output), restore (--snapshot), rotate-dek (--emergency flag for dual-control path), confirm-rotate-dek (--rotation-id), metrics (leader / voters / raw OpenRaft metrics) - Update doc/src/raft_storage.md: add CLI reference table, Cluster Metrics runbook section, and fix all flag inconsistencies (--node-addr/--leader-addr -> --addr; positional args for init/join/promote) Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-Off-By: Artem Goncharov <artem.goncharov@gmail.com>
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
|
|
| Branch | cli-raft |
| Testbed | ubuntu-latest |
🚨 2 Alerts
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| Payload_encryption/unpack/set_cmd | Latency nanoseconds (ns) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 311.83 ns(+20.79%)Baseline: 258.16 ns | 311.53 ns (100.10%) |
| Raft_1Node_Latency/read/1node | Latency microseconds (µs) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.39 µs(+124.92%)Baseline: 0.62 µs | 1.10 µs (126.76%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 190,470.00 ns(-8.62%)Baseline: 208,443.53 ns | 993,156.76 ns (19.18%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 281,690.00 ns(+44.33%)Baseline: 195,175.89 ns | 856,762.52 ns (32.88%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 121.63 ns(+1.71%)Baseline: 119.59 ns | 144.46 ns (84.20%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 109.54 ns(-1.08%)Baseline: 110.74 ns | 134.95 ns (81.17%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 195.47 ns(+1.27%)Baseline: 193.02 ns | 238.27 ns (82.04%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 109.41 ns(-1.35%)Baseline: 110.91 ns | 134.94 ns (81.08%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 187.97 ns(-1.46%)Baseline: 190.75 ns | 234.04 ns (80.31%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 162.34 ns(-1.35%)Baseline: 164.56 ns | 204.04 ns (79.56%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 274.46 ns(+11.30%)Baseline: 246.59 ns | 298.27 ns (92.02%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 157.92 ns(-2.97%)Baseline: 162.76 ns | 200.20 ns (78.88%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 112.59 ns(-5.41%)Baseline: 119.03 ns | 153.34 ns (73.43%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 228.87 ns(+6.54%)Baseline: 214.83 ns | 285.42 ns (80.19%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 205.18 ns(+2.13%)Baseline: 200.89 ns | 246.86 ns (83.12%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 311.83 ns(+20.79%)Baseline: 258.16 ns | 311.53 ns (100.10%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 2,007,500.00 ns(-41.30%)Baseline: 3,420,077.81 ns | 7,026,405.79 ns (28.57%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1,391.60 ns(+124.92%)Baseline: 618.72 ns | 1,097.79 ns (126.76%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 567,040.00 ns(+13.88%)Baseline: 497,929.06 ns | 2,187,439.70 ns (25.92%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 596,200.00 ns(+29.91%)Baseline: 458,917.03 ns | 1,589,881.60 ns (37.50%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 102,970.00 ns(+5.89%)Baseline: 97,237.88 ns | 172,671.19 ns (59.63%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,423.70 ns(+2.31%)Baseline: 1,391.60 ns | 1,634.44 ns (87.11%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.31 ns(-2.42%)Baseline: 0.32 ns | 0.38 ns (81.60%) |
| get_db | 📈 view plot 🚷 view threshold | 0.31 ns(-2.73%)Baseline: 0.32 ns | 0.38 ns (81.36%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 172.78 ns(+19.76%)Baseline: 144.27 ns | 176.00 ns (98.17%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.38 ns(-7.94%)Baseline: 4.76 ns | 8.80 ns (49.79%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement backup, restore, rotate-dek, confirm-rotate-dek, and metrics
subcommands for keystone-manage storage, completing CLI coverage for all
Raft cluster operations defined in ADR 0016-v2.
handlers): server-streaming Backup chunks the encrypted snapshot at
256 KiB; client-streaming Restore accumulates chunks and calls
install_full_snapshot
use by the restore handler (validates AES-256-GCM envelope, returns
OpenRaft Snapshot ready for install_full_snapshot)
backup handler can call build_snapshot() and read the resulting
encrypted file
(--emergency flag for dual-control path), confirm-rotate-dek
(--rotation-id), metrics (leader / voters / raw OpenRaft metrics)
Metrics runbook section, and fix all flag inconsistencies
(--node-addr/--leader-addr -> --addr; positional args for
init/join/promote)
Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com
Signed-Off-By: Artem Goncharov artem.goncharov@gmail.com