Skip to content

fix(ci): Prepare workflows for merge queue#902

Merged
gtema merged 1 commit into
mainfrom
fix/merge-queue-ci
Jul 2, 2026
Merged

fix(ci): Prepare workflows for merge queue#902
gtema merged 1 commit into
mainfrom
fix/merge-queue-ci

Conversation

@gtema

@gtema gtema commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator
  • committed action was silently ignoring its merge_group override:
    crate-ci/committed reads the commits input, not a COMMITTED_REV env
    var, so on merge_group it kept using the default HEAD~..HEAD^2 range,
    which doesn't resolve on the queue's single-commit ref.
  • ci.yml and functional.yml gated required jobs behind pull_request
    path filters, so a required status check on those jobs would never
    report on PRs that don't touch matched paths, blocking merge forever.
    Both workflows now always trigger and use dorny/paths-filter in a new
    changes job to skip the actual work when nothing relevant changed,
    so the check always reports.

Apparently due to the wrong filters the clippy job was not properly
running, which is why unrelated clippy fixes are included.

Signed-off-by: Artem Goncharov Artem.goncharov@gmail.com

@gtema
gtema added this pull request to the merge queue Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

🦢 Load Test Results

Goose Attack Report

Plan Overview

Action Started Stopped Elapsed Users
Increasing 26-07-02 15:58:53 26-07-02 15:59:10 00:00:17 0 → 30
Maintaining 26-07-02 15:59:10 26-07-02 15:59:40 00:00:30 30
Decreasing 26-07-02 15:59:40 26-07-02 15:59:40 00:00:00 0 ← 30

Request Metrics

Method Name # Requests # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
DELETE DELETE /v3/auth/tokens 486 0 112.37 14 177 16.20 0.00
DELETE DELETE /v3/projects/:id (teardown) 2 0 52.50 32 73 0.07 0.00
DELETE DELETE /v3/users/:id (teardown) 3 0 39.00 30 46 0.10 0.00
GET 4443 0 105.81 71 195 148.10 0.00
GET GET /v3/auth/tokens (validate new) 485 0 112.45 34 138 16.17 0.00
GET GET /v3/projects/:id 695 0 86.26 72 108 23.17 0.00
GET GET /v3/projects/:id (catalog) 687 0 86.92 74 112 22.90 0.00
GET GET /v3/users/:id 969 0 92.84 78 119 32.30 0.00
GET GET /v3/users/:id (catalog) 759 0 92.62 81 128 25.30 0.00
POST POST /v3/auth/tokens 482 0 85.37 74 109 16.07 0.00
Aggregated 9011 0 99.94 14 195 300.37 0.00

Response Time Metrics

Method Name 50%ile (ms) 60%ile (ms) 70%ile (ms) 80%ile (ms) 90%ile (ms) 95%ile (ms) 99%ile (ms) 100%ile (ms)
DELETE DELETE /v3/auth/tokens 110 110 120 120 120 120 130 177
DELETE DELETE /v3/projects/:id (teardown) 32 32 32 73 73 73 73 73
DELETE DELETE /v3/users/:id (teardown) 41 41 41 41 46 46 46 46
GET 97 100 110 110 160 170 180 195
GET GET /v3/auth/tokens (validate new) 110 110 120 120 120 120 130 138
GET GET /v3/projects/:id 86 87 88 90 93 95 100 108
GET GET /v3/projects/:id (catalog) 86 87 89 91 93 96 100 110
GET GET /v3/users/:id 92 93 95 97 99 100 110 119
GET GET /v3/users/:id (catalog) 92 93 95 96 99 100 110 128
POST POST /v3/auth/tokens 85 86 87 89 92 96 100 109
Aggregated 92 97 100 110 120 160 170 195

Status Code Metrics

Method Name Status Codes
DELETE DELETE /v3/auth/tokens 486 [204]
DELETE DELETE /v3/projects/:id (teardown) 2 [204]
DELETE DELETE /v3/users/:id (teardown) 3 [204]
GET 4,443 [200]
GET GET /v3/auth/tokens (validate new) 485 [200]
GET GET /v3/projects/:id 695 [200]
GET GET /v3/projects/:id (catalog) 687 [200]
GET GET /v3/users/:id 969 [200]
GET GET /v3/users/:id (catalog) 759 [200]
POST POST /v3/auth/tokens 482 [200]
Aggregated 8,520 [200], 491 [204]

Transaction Metrics

Transaction # Times Run # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
ReadHeavy
0.0 1 0 33.00 33 33 0.03 0.00
0.1 755 0 104.63 81 138 25.17 0.00
0.2 752 0 87.26 75 109 25.07 0.00
0.3 753 0 87.00 71 112 25.10 0.00
TokenLifecycle
1.0 0 0 0.00 0 0 0.00 0.00
1.1 486 0 311.28 127 376 16.20 0.00
ValidateToken
2.0 0 0 0.00 0 0 0.00 0.00
2.1 735 0 163.94 113 195 24.50 0.00
UserCRUD
3.0 0 0 0.00 0 0 0.00 0.00
3.1 0 0 0.00 0 0 0.00 0.00
3.2 969 0 92.89 78 119 32.30 0.00
3.3 3 0 39.00 30 46 0.10 0.00
ProjectCRUD
4.0 0 0 0.00 0 0 0.00 0.00
4.1 0 0 0.00 0 0 0.00 0.00
4.2 695 0 86.31 73 109 23.17 0.00
4.3 2 0 52.50 32 73 0.07 0.00
UserRead
5.0 0 0 0.00 0 0 0.00 0.00
5.1 760 0 104.67 90 133 25.33 0.00
5.2 759 0 92.67 81 128 25.30 0.00
ProjectRead
6.0 0 0 0.00 0 0 0.00 0.00
6.1 688 0 87.42 74 111 22.93 0.00
6.2 687 0 86.98 74 112 22.90 0.00
Aggregated 8045 0 111.94 30 376 268.17 0.00

Scenario Metrics

Transaction # Users # Times Run Average (ms) Min (ms) Max (ms) Scenarios/s Iterations
ReadHeavy 7 751 280.03 255 317 25.03 107.29
TokenLifecycle 5 481 312.14 286 376 16.03 96.20
ValidateToken 4 731 164.08 145 195 24.37 182.75
UserCRUD 3 966 92.92 78 119 32.20 322.00
ProjectCRUD 2 693 86.33 73 109 23.10 346.50
UserRead 5 757 197.87 179 232 25.23 151.40
ProjectRead 4 684 174.95 156 209 22.80 171.00
Aggregated 30 5063 177.65 73 376 168.77 1377.14

View full report

@gtema
gtema removed this pull request from the merge queue due to a manual request Jul 2, 2026
@gtema
gtema force-pushed the fix/merge-queue-ci branch 4 times, most recently from c188029 to e089b16 Compare July 2, 2026 14:39
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Branchfix/merge-queue-ci
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
Command_Serde/apply/remove📈 view plot
🚷 view threshold
135,480.00 ns
(-52.16%)Baseline: 283,221.33 ns
1,686,423.26 ns
(8.03%)
Command_Serde/apply/set📈 view plot
🚷 view threshold
144,460.00 ns
(-38.31%)Baseline: 234,153.67 ns
983,724.82 ns
(14.69%)
Command_Serde/pack/delete📈 view plot
🚷 view threshold
124.68 ns
(+3.48%)Baseline: 120.49 ns
142.24 ns
(87.66%)
Command_Serde/pack/delete_index📈 view plot
🚷 view threshold
112.09 ns
(+2.13%)Baseline: 109.76 ns
129.40 ns
(86.62%)
Command_Serde/pack/set📈 view plot
🚷 view threshold
209.82 ns
(+8.58%)Baseline: 193.24 ns
231.58 ns
(90.61%)
Command_Serde/pack/set_index📈 view plot
🚷 view threshold
112.11 ns
(+2.34%)Baseline: 109.55 ns
128.77 ns
(87.06%)
Command_Serde/unpack/delete📈 view plot
🚷 view threshold
201.90 ns
(+4.69%)Baseline: 192.85 ns
233.48 ns
(86.47%)
Command_Serde/unpack/delete_index📈 view plot
🚷 view threshold
157.54 ns
(-1.74%)Baseline: 160.32 ns
195.96 ns
(80.40%)
Command_Serde/unpack/set📈 view plot
🚷 view threshold
287.46 ns
(+9.69%)Baseline: 262.06 ns
324.38 ns
(88.62%)
Command_Serde/unpack/set_index📈 view plot
🚷 view threshold
175.57 ns
(+10.30%)Baseline: 159.17 ns
193.44 ns
(90.76%)
Payload_encryption/pack/remove_cmd📈 view plot
🚷 view threshold
123.88 ns
(+6.39%)Baseline: 116.44 ns
138.78 ns
(89.26%)
Payload_encryption/pack/set_cmd📈 view plot
🚷 view threshold
222.62 ns
(+8.39%)Baseline: 205.40 ns
271.81 ns
(81.90%)
Payload_encryption/unpack/remove_cmd📈 view plot
🚷 view threshold
214.03 ns
(+4.25%)Baseline: 205.30 ns
248.00 ns
(86.30%)
Payload_encryption/unpack/set_cmd📈 view plot
🚷 view threshold
302.91 ns
(+10.12%)Baseline: 275.06 ns
340.71 ns
(88.91%)
Raft_1Node_Latency/prefix/1node📈 view plot
🚷 view threshold
2,653,300.00 ns
(-8.19%)Baseline: 2,890,072.97 ns
6,573,432.09 ns
(40.36%)
Raft_1Node_Latency/read/1node📈 view plot
🚷 view threshold
44,364.00 ns
(+349.57%)Baseline: 9,868.13 ns
50,764.35 ns
(87.39%)
Raft_1Node_Latency/remove/1node📈 view plot
🚷 view threshold
385,010.00 ns
(-29.73%)Baseline: 547,930.16 ns
2,295,486.44 ns
(16.77%)
Raft_1Node_Latency/write/1node📈 view plot
🚷 view threshold
406,750.00 ns
(-28.48%)Baseline: 568,723.75 ns
2,128,606.52 ns
(19.11%)
build_snapshot/default📈 view plot
🚷 view threshold
120,600.00 ns
(+13.88%)Baseline: 105,903.06 ns
161,989.09 ns
(74.45%)
fernet token/project📈 view plot
🚷 view threshold
1,435.30 ns
(+3.70%)Baseline: 1,384.10 ns
1,620.91 ns
(88.55%)
get_data_keyspace📈 view plot
🚷 view threshold
0.31 ns
(-0.94%)Baseline: 0.32 ns
0.37 ns
(84.73%)
get_db📈 view plot
🚷 view threshold
0.31 ns
(-1.11%)Baseline: 0.32 ns
0.37 ns
(84.68%)
get_fernet_token_timestamp/project📈 view plot
🚷 view threshold
133.47 ns
(-7.43%)Baseline: 144.18 ns
179.14 ns
(74.51%)
get_keyspace📈 view plot
🚷 view threshold
4.40 ns
(-6.65%)Baseline: 4.71 ns
8.74 ns
(50.27%)
🐰 View full continuous benchmarking report in Bencher

@gtema
gtema force-pushed the fix/merge-queue-ci branch 2 times, most recently from 169c6c5 to 4157179 Compare July 2, 2026 15:20
- committed action was silently ignoring its merge_group override:
  crate-ci/committed reads the commits input, not a COMMITTED_REV env
  var, so on merge_group it kept using the default HEAD~..HEAD^2 range,
  which doesn't resolve on the queue's single-commit ref.
- ci.yml and functional.yml gated required jobs behind pull_request
  path filters, so a required status check on those jobs would never
  report on PRs that don't touch matched paths, blocking merge forever.
  Both workflows now always trigger and use dorny/paths-filter in a new
  changes job to skip the actual work when nothing relevant changed,
  so the check always reports.

Apparently due to the wrong filters the clippy job was not properly
running, which is why unrelated clippy fixes are included.

Signed-off-by: Artem Goncharov <Artem.goncharov@gmail.com>
@gtema
gtema force-pushed the fix/merge-queue-ci branch from 4157179 to ce89f71 Compare July 2, 2026 15:46
@gtema
gtema enabled auto-merge July 2, 2026 16:02
@gtema
gtema disabled auto-merge July 2, 2026 16:09
@gtema
gtema enabled auto-merge July 2, 2026 16:09
@gtema
gtema disabled auto-merge July 2, 2026 16:18
@gtema
gtema enabled auto-merge July 2, 2026 16:18
@gtema
gtema disabled auto-merge July 2, 2026 16:23
@gtema
gtema enabled auto-merge July 2, 2026 16:23
@gtema
gtema disabled auto-merge July 2, 2026 16:25
@gtema
gtema merged commit 7a6fc84 into main Jul 2, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant