Skip to content

[ci] Update PR validation workflow - #659

Merged
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow
Jul 31, 2026
Merged

[ci] Update PR validation workflow#659
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow

Conversation

@nemesifier

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines and OpenWISP Anti AI Spam Policy.
  • N/A. This GitHub Actions caller-workflow change has no local manual execution path.
  • N/A. No application code changed.
  • N/A. No user-facing behavior or documentation changed.

Reference to Existing Issue

Related to openwisp/openwisp-utils#716

Description of Changes

Adds edited and ready_for_review pull request events so the shared workflow promptly revalidates changed descriptions. Makes the concurrency key PR-specific so newer events cancel outdated validation runs.

Screenshot

N/A. This is a GitHub Actions workflow-only change.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b7fd7fe2-4ab3-40a3-a934-48ebb78cc150

📥 Commits

Reviewing files that changed from the base of the PR and between 4a3c579 and 61c70b1.

📒 Files selected for processing (1)
  • .github/workflows/bot-autoassign-pr-issue-link.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Kilo Code Review
🧰 Additional context used
🪛 zizmor (1.28.0)
.github/workflows/bot-autoassign-pr-issue-link.yml

[error] 7-7: overly broad permissions (excessive-permissions): issues: write is overly broad at the workflow level

(excessive-permissions)


[warning] 7-7: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)

🔇 Additional comments (1)
.github/workflows/bot-autoassign-pr-issue-link.yml (1)

4-4: LGTM!

Also applies to: 9-10


📝 Walkthrough

Walkthrough

The pull request workflow now triggers for edited and ready_for_review events in addition to opened, reopened, and closed. Its concurrency group no longer includes the event action, so runs are grouped by repository and pull request number. Permissions and downstream job wiring are unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 6 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Features ⚠️ Warning This feature change has no issue acceptance evidence, documentation update, or added tests; the description only links PR openwisp-utils#716 and marks documentation and application-code changes N/A. Link an accepted issue with organization-member validation, document the workflow behavior, and add workflow-focused tests or explain an approved test exemption.
Changes ⚠️ Warning The workflow changes trigger and concurrency behavior, but the commit adds no tests; it changes only workflow YAML. UI, documented behavior, and public API migration requirements do not apply. Add a workflow-level validation test for the new events and PR-specific concurrency, or provide repository-supported validation that covers this behavior.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the required [ci] prefix and accurately describes the workflow changes.
Description check ✅ Passed The description includes the checklist, issue reference, change summary, and screenshot section with applicable N/A entries.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed The PR changes only a GitHub Actions workflow; the check explicitly allows omitting regression tests for fixes affecting GitHub Actions workflows.
General Rules ✅ Passed PR satisfies all general rules: no security vulnerabilities, no performance regressions, clear code, proper formatting, no unused code, accurate documentation, descriptive names, follows AGENTS.md...
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/update-pr-validation-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nemesifier
nemesifier force-pushed the ci/update-pr-validation-workflow branch from 4a3c579 to 61c70b1 Compare July 31, 2026 13:09
@kilo-code-bot

kilo-code-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/bot-autoassign-pr-issue-link.yml

Reviewed by ling-3.0-flash:free · Input: 78.5K · Output: 6.1K · Cached: 212.3K

@nemesifier
nemesifier merged commit d9c93b1 into master Jul 31, 2026
6 checks passed
@nemesifier
nemesifier deleted the ci/update-pr-validation-workflow branch July 31, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant