Skip to content

[chores/docs] Remove HTTP and SSH backends #53 - #54

Merged
nemesifier merged 3 commits into
masterfrom
issues/53-remove-unused-code
May 26, 2021
Merged

[chores/docs] Remove HTTP and SSH backends #53#54
nemesifier merged 3 commits into
masterfrom
issues/53-remove-unused-code

Conversation

@purhan

@purhan purhan commented May 23, 2021

Copy link
Copy Markdown
Contributor

Resolves part of #53

@pandafy pandafy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @purhan. Some minor improvements can be done.

Comment thread docs/source/index.rst Outdated

The legacy versions of this project had support for SSH and HTTP for extracting information from
devices. To see how it worked, visit the
`0.1.0 pre-alpha release <https://github.com/openwisp/netengine/releases/tag/0.1.0a>`_ page on

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the docs provides versioned documentation. If it is not much work to set it up, then we can enable that and use that link here instead.

If above is not quickly doable, then we can link https://github.com/openwisp/netengine/tree/0.1.0a instead of the tag. We can update this link later while releasing the module

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it was an alpha release, not pre-alpha.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note in #56, if you want to delegate enabling versioned documentation. So we remember that we need to take care of this.

Comment thread docs/source/index.rst
Comment thread test-settings.example.json
@purhan
purhan requested a review from pandafy May 24, 2021 10:29
Comment thread docs/source/conf.py
@pandafy
pandafy requested a review from nemesifier May 24, 2021 10:43
Comment thread docs/source/index.rst Outdated

@nemesifier nemesifier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some dependencies like paramiko and mechanize were pulled because of http and ssh backends, make sure the dependencies that are not needed anymore are removed.

@nemesifier nemesifier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

Comment thread requirements.txt
@@ -1,6 +1,3 @@
paramiko
pysnmp
ipaddress

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we migrate to python3 we should be able to remove this as well, let's keep in mind.

@nemesifier
nemesifier merged commit 9646440 into master May 26, 2021
@purhan
purhan deleted the issues/53-remove-unused-code branch May 26, 2021 08:33
@pandafy pandafy mentioned this pull request May 26, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants