[misc] Python3 support, Github CI and QA Checks - #59
Conversation
pandafy
left a comment
There was a problem hiding this comment.
I believe it will work after rebasing on current master.
3ac707a to
c8a4566
Compare
This comment has been minimized.
This comment has been minimized.
7284efd to
75f77fe
Compare
pandafy
left a comment
There was a problem hiding this comment.
Here is my initial review. I will look up the code again to see if anything got left out.
@purhan it will be easier for you later to squash commits later if you keep commits on this PR atomic. Remember we will merge 4 commits in the end.
We should look for a workaround for now since rest of OpenWISP currently supports Python 3.6 and 3.7. diff --git a/tests/test_snmp/test_airos.py b/tests/test_snmp/test_airos.py
index 56234d0..fc190e2 100644
--- a/tests/test_snmp/test_airos.py
+++ b/tests/test_snmp/test_airos.py
@@ -168,4 +168,7 @@ class TestSNMPAirOS(unittest.TestCase, MockOutputMixin):
self.assertIsInstance(self.device.uptime_tuple, tuple)
def tearDown(self):
- self.getcmd_patcher.stop()
+ try:
+ self.getcmd_patcher.stop()
+ except RuntimeError:
+ returnDon't forget to add a comment stating why this has been done and to remove it once support for Python 3.8 an above is added. |
| u'Alessandro Bucciarelli, Federico Capoano', | ||
| 'netengine', | ||
| 'One line description of project.', | ||
| 'Miscellaneous', |
There was a problem hiding this comment.
shall we update this since we are here or shall we do this later?
There was a problem hiding this comment.
I think it may be better to do this in #56
Or we can do this here, what would you suggest changing this to?
|
Note: We have to configure the coveralls bot to comment on PRs. |
nemesifier
left a comment
There was a problem hiding this comment.
I made sure coveralls is enabled: https://coveralls.io/github/openwisp/netengine.
I left one minor request regarding link 404 verification, see below.
pandafy
left a comment
There was a problem hiding this comment.
LGTM! 👍🏼
Deferring merge to @nemesisdesign
nemesifier
left a comment
There was a problem hiding this comment.
@purhan LGTM!
I don't think squashing everything in one commit will be good, can you squash commits so we have one commit closing each issue mentioned?
Closes #50
Closes #50, closes #49, closes #52, closes #55, closes #61