wifi: mt76: clean up station WCID and TX queues before sta_remove - #1125
Open
astrouski-google wants to merge 1 commit into
Open
astrouski-google wants to merge 1 commit into
astrouski-google wants to merge 1 commit into
Conversation
When a station is removed, __mt76_sta_remove() previously called dev->drv->sta_remove() before calling mt76_wcid_cleanup(). Because dev->drv->sta_remove() informs the hardware/firmware that the station's WCID is released, having un-transmitted packets in wcid->tx_pending/tx_offchannel or having the station still present on phy->tx_list during or after sta_remove can cause concurrent TX workers to attempt transmission on an unassigned/freed hardware WCID. Move mt76_wcid_cleanup() before dev->drv->sta_remove() so that TX polling and scheduling are halted under phy->tx_lock and all pending TX frames are cleanly flushed via ieee80211_free_txskb() before the hardware/firmware is notified. Signed-off-by: Alexander Astrovsky <astrouski@google.com>
|
@nbd168 seems like a quick fix, do you still want @astrouski-google to send it to the mailing list? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a station is removed, __mt76_sta_remove() previously called dev->drv->sta_remove() before calling mt76_wcid_cleanup().
Because dev->drv->sta_remove() informs the hardware/firmware that the station's WCID is released, having un-transmitted packets in wcid->tx_pending/tx_offchannel or having the station still present on phy->tx_list during or after sta_remove can cause concurrent TX workers to attempt transmission on an unassigned/freed hardware WCID.
Move mt76_wcid_cleanup() before dev->drv->sta_remove() so that TX polling and scheduling are halted under phy->tx_lock and all pending TX frames are cleanly flushed via ieee80211_free_txskb() before the hardware/firmware is notified.