refactor: updateMatcher removal - #2431
Merged
Merged
Conversation
csviri
force-pushed
the
remove-update-matcher
branch
from
June 18, 2024 07:41
f0322f3 to
18cd029
Compare
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
remove-update-matcher
branch
from
June 28, 2024 12:19
18cd029 to
96904e3
Compare
metacosm
approved these changes
Jul 2, 2024
metacosm
approved these changes
Jul 2, 2024
metacosm
pushed a commit
that referenced
this pull request
Jul 8, 2024
metacosm
pushed a commit
that referenced
this pull request
Jul 9, 2024
metacosm
pushed a commit
that referenced
this pull request
Jul 12, 2024
csviri
added a commit
that referenced
this pull request
Aug 8, 2024
csviri
added a commit
that referenced
this pull request
Aug 15, 2024
metacosm
pushed a commit
that referenced
this pull request
Aug 29, 2024
csviri
added a commit
that referenced
this pull request
Sep 20, 2024
metacosm
pushed a commit
that referenced
this pull request
Oct 10, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 5, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 6, 2024
csviri
added a commit
that referenced
this pull request
Nov 13, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 19, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 20, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 27, 2024
This was referenced Dec 3, 2024
csviri
added a commit
that referenced
this pull request
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there wast just one
UpdateMatcherimplementation, while it was explicitly in the code that SSA is handled differently.This PR removes the updateMatcher concept, and makes it explicit that SSA uses the ssa matcher and SSA updater, and also the same holds for the generic matcher and updater.
While I don't disagree with the updateMatcher concept there will be no other combinations than these two.