Skip to content

fix: supervise Orca issue pickup - #16

Merged
lemarier merged 1 commit into
mainfrom
lemarier/supervise-issue-pickup
Sep 26, 2026
Merged

lemarier merged 1 commit into
mainfrom
lemarier/supervise-issue-pickup

Conversation

@lemarier

Copy link
Copy Markdown
Contributor

Idle pickup launched standalone workers and ended immediately, leaving no coordinator to receive questions or report progress. Require a supervised Run, Task and Dispatch, keep the coordinator inbox active through settlement, and route multi-repository work through one conversation. Preserve standalone launch for explicit ownership handoffs.

Document issue linking, launch recovery, missing-information handling and terminal cleanup, and add corresponding skill-validation scenarios.

Validation: just check passed all 32 tests; git diff --check passed. A live Orca smoke test verified worker ask, coordinator reply, worker completion with the received token, and terminal release. The scheduled issue-pickup flow itself has not been exercised end to end.

Copilot AI lite review requested due to automatic review settings September 26, 2026 14:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T14:32:23.005952Z cc83b06 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Advanced

Run ID: cfa16037-20b4-45ce-99fb-0f688b50e627

📥 Commits

Reviewing files that changed from the base of the PR and between 45507a1 and cc83b06.

📒 Files selected for processing (3)
  • docs/skill-validation.md
  • skills/origin89-orca/SKILL.md
  • skills/origin89-orca/references/unattended-run.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The Orca guidance now describes supervised worker launches and worktree linking for issue work. Unattended-run instructions cover coordinator activity from issue pickup through worker settlement, including messaging, authority limits, and recovery when launch outcomes are uncertain. Validation scenarios cover active-worker pickup limits, worker questions, unknown start outcomes, unsupervised handoffs, and final worker outcomes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Merge Risk: ⚪ Minimal · up to cc83b

No established defect prevents merging. Confirm that the deployed Orca session can remain available through worker settlement before enabling scheduled pickup.

Architecture Summary

Architecture risk: 🔵 Low · up to cc83b

The change affects 2 systems.

Changed systems: skills, docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — skills (service) was modified; 2 changed files map to changed impact.
  • observed — docs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/skill-validation.md: The idle-pickup scenario now skips when a worker is working or waiting for a reply and the limit is one. Added scenarios specify the expected handling of a ready issue, supervised worker questions, unknown start outcomes, unsupervised handoffs, and final worker outcomes.
  • observed — Modified behavior in skills/origin89-orca/SKILL.md: The default issue workflow now creates an orchestration Run and launches a worker with worker-start, then links the returned worktree to the issue. It requires the coordinator to handle messages until Dispatch settles and account for its terminal. Direct worktree create is now reserved for handoffs without supervision or coordinated messaging; supervised attempts are listed through worker-list.
  • observed — Modified behavior in skills/origin89-orca/SKILL.md: Sub-issue worktrees are now linked with worktree set --issue; sub-issues in another repository still receive a worker there.
  • observed — Modified behavior in skills/origin89-orca/SKILL.md: Writer workers now use new-top-level worktrees for independent issues and new-child worktrees for related work, replacing the prior new-child default.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: supervised Orca issue pickup.
Description check ✅ Passed The description explains the problem, resulting behavior, scope, validation commands, smoke-test coverage, and the unperformed end-to-end check.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@lemarier
lemarier merged commit a2dbbe5 into main Sep 26, 2026
2 checks passed
@lemarier
lemarier deleted the lemarier/supervise-issue-pickup branch September 26, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants