Skip to content

fix: preserve parent guidance during reviews - #26

Draft
lemarier wants to merge 1 commit into
mainfrom
lemarier/keep-parent-guidance-visible-during-supervised-r
Draft

lemarier wants to merge 1 commit into
mainfrom
lemarier/keep-parent-guidance-visible-during-supervised-r

Conversation

@lemarier

Copy link
Copy Markdown
Contributor

Change

A supervised implementation worker can bind itself to a child Run before discovering that the nesting limit prevents launching reviewers. Route review placement through the parent coordinator and require a guidance/reply exchange after Run binding changes. Document parent Dispatch mailbox inspection and child Run recovery without parent takeover or duplicate workers, plus explicit reviewer and implementation release accounting.

Update supervised pickup guidance and add validation scenarios for normal parent placement, rejected nested launches, unread guidance, and uncertain launch effects. Shared guidance refreshes at the next adopted task; no workflow or executable template changes and no package changeset are needed.

Refs #17.

Validation

  • just check: all 32 tests passed, including canonical skill bundle, frontmatter, notices, local links, and JSON checks.
  • git diff --check: passed.
  • Checked command guidance against the installed Orca 1.4.212 orchestration references and help. Manually reviewed all changed Markdown; ocr review --preview excludes all three files as unsupported extensions.
  • Pending: live implementation worker plus review panel under max depth 1, including guidance read/reply/acknowledgment, rejected nested-launch recovery, no duplicate workers, and explicit release of every Dispatch. Agent-family selection is awaiting confirmation. This draft does not claim behavioral acceptance or resolution of the underlying runtime inbox behavior.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@lemarier

Copy link
Copy Markdown
Contributor Author

Decision (lemarier, Roger Ask 01M3HFJW9YGW0S5KQX484SF3G4): "Use Codex + Claude". Approved: a Codex implementation worker and a Codex + Claude review panel, configured default models, for the disposable acceptance scenarios in #17 only. This grants no merge, release, deployment or equipment operation. Recorded for the session that owns this PR; nothing has been launched from this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant