Switch rolling to *always* use testing repositories.#122
Open
clalancette wants to merge 1 commit into
Open
Conversation
The ROS PMC is considering a change to only support the testing repository for Rolling. While that change hasn't been finalized yet, it is not a bad idea for the Rolling docker images to always use testing; it is Rolling, after all, and whether it is unstable in testing in main or unstable in testing is mostly irrelevant. Update the code here to always have rolling point to the testing repositories. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Author
|
Note for reviewers: I have no idea how to test this out, any ideas welcome. |
MatthijsBurgh
approved these changes
Jun 23, 2026
MatthijsBurgh
left a comment
There was a problem hiding this comment.
Logic seems correct to me.
I also don't know how to test this.
Member
I've been out of the loop for a while, was this settled on by the ROS PMC? |
Author
This was discussed in the ROS PMC meeting a few weeks ago: The short of it is that it is still up in the air. But I think that we should make this change now so that we can unblock the Rolling Docker images for now. If the PMC makes a different choice, we can always follow suit later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ROS PMC is considering a change to only support the testing repository for Rolling. While that change hasn't been finalized yet, it is not a bad idea for the Rolling docker images to always use testing; it is Rolling, after all, and whether it is unstable in testing in main or unstable in testing is mostly irrelevant. Update the code here to always have rolling point to the testing repositories.