addresses code review#10
Merged
Merged
Conversation
update larch pin to 6.0.46 and all dependabot changes
…im#1023) * skip hh in simple simulate * retain `household_id` by default in the drop_unused_columns() we need it for debug tracing and skipping failed hh * skip choice for interaction sample simulate * don't log hh id when bad choice df is empy * add hh id to user specified `chooser_columns` when `chooser_columns` exist * blacken * update test utils to probs raises * [skip ci] shadow price calc without failed choices * [skip ci] special case in trip mode choice * [skip ci] adjust sample_rate * [skip ci] add final logging of num hh skipped * unit test * update CI * track and summarize failed households by component * `skipped_household_ids` is now a dictionary * print more loggings about trips missing modes * adjust trip expansion factor using hh weight instead of count * update state tables only when new households are skipped * put a limit on num of households allowed to skip * auto debug tracing newly failed choice * update test * Add documentation to user guide * update doc * increase sample rate decimals * handle zero `sample_rate` when calculating weights * black * [skip ci] confirm trace files are generated for skipped hh * Revert "increase sample rate decimals" This reverts commit a734c16. * add note for not rounding sample rate * write trip matrices even when `sample_rate` is all zero To pass this single hh test: https://github.com/ActivitySim/activitysim/actions/runs/23202170408/job/67427319813?pr=1023
…im#1063) * change default to 0.1% hh allowed to be skipped * [skip ci] update doc * add to change log
* removing tvpb from models * remove core 3-zone code * removing tests and examples * blacken * remove pathbuilder import calls * remove references to initialize_los * removing sandag 3 zone and doc references * fix skim name conflict test * fixing failed choice test
* use all TAZs when using sharrow * better error message * change default fastmath to false * blacken * changelog note * change from dims to sizes, reduces warnings * require numpy 2.0 * lock update numpy * unpin pandera, update to latest * fixes for numpy 2.0 * address pandera import warnings * fix offset overflow * stable sorting of ProtoPop * update pins for nbmake and pytest * update lockfile
* remove `sample_rate` rounding * create a unit test for sample rate calculation * apply the modified copilot review changes
…tivitySim#1031) * optimize nearest_zone from skims function * increase speed of skim dict _lookup mapping function * blacken * handle empty inputs for nearest zone calc * maz span not dependent on numbering Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * map based on index instead of number * batching skim lookup for disagg access nearest zone * Revert "Merge branch 'disagg_access_nearest_zone_speed_up' of https://github.com/RSGInc/activitysim into disagg_access_nearest_zone_speed_up" This reverts commit a9b7f69, reversing changes made to 66ae28c. * Revert "map based on index instead of number" This reverts commit 66ae28c. * Reapply "map based on index instead of number" This reverts commit f1e135e. * Reapply "Merge branch 'disagg_access_nearest_zone_speed_up' of https://github.com/RSGInc/activitysim into disagg_access_nearest_zone_speed_up" This reverts commit 6c6367f. --------- Co-authored-by: Jeffrey Newman <jeff@driftless.xyz> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.