Skip to content

A PR is one idea, not one knob - #430

Merged
renmengye merged 2 commits into
mainfrom
docs/idea-not-knob
Sep 26, 2026
Merged

renmengye merged 2 commits into
mainfrom
docs/idea-not-knob

Conversation

@renmengye

Copy link
Copy Markdown
Member

Recent gpt-speedrun PRs show two patterns the old rule produced.

Owner decisions: a combination is fine when the joint effect is genuine and each single effect is documented. A single-point tuning PR may be blocking when the report gives no picture of the landscape (a sweep, neighbouring values, or an ablation); this is a judgment, not an absolute rule. Fundamental ideas are encouraged even when they don't yet beat the best.

What changes (wording and one additive category)

  • Panel instruction on research-line targets: a PR is one idea. An idea may bring the few changes it needs, such as the hyperparameters it shifts, when the report documents each change's own effect. Independent ideas bundled together, or a win the report does not attribute, stay blocking.
  • Verifier rubric.
    • aggregation now accepts a genuine combination with per-change effects. It still rejects an even blend of small tweaks with no stated mechanism.
    • A new landscape category covers single-point hyperparameter or capacity changes with no sweep, neighbours or ablation behind them. It also asks a size-only win to argue why size is the right lever.
  • Author brief.
    • One idea per PR; a larger idea touching several places is welcome with its mechanism stated.
    • Sweep in one array launch and show the landscape around the chosen value.
    • A clear idea that doesn't yet win is a success to report, and the author's research line keeps it.
  • Architecture doc: "one hypothesis per PR" becomes "one idea per PR", with attribution required.

Compatibility

Prompts and rubric text only, plus an additive finding category; a reader that does not know landscape treats it as other. No persisted state changes. It applies from the next panel read.

🤖 Generated with Claude Code

The panel instruction, the verifier rubric, the author brief and the
architecture doc now treat one idea, not one change, as the unit: an
idea may bring the few changes it needs when the report attributes
each, independent ideas bundled together stay blocking, and a new
"landscape" category lets the panel block single-point tuning with no
sweep or ablation behind it. Authors are told to sweep in one array
launch and that a promising idea without a win is a success to report.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1 — reviewed head c5aff9f4 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: nothing blocking — 2 advisory notes.

Advisory (non-blocking):

  • Suggestion: Research-line brief still requires one clean contribution. [coverage+prose] A PR to main must be one idea, and may include the related changes it needs when the report gives each change’s own effect. (src/outerloop/brief.py:280; high confidence)
  • Generated PRs still tell authors to use one hypothesis. [credentials] The changed policy allows one idea with several attributed changes, but generated PR bodies still say one hypothesis per PR, which can discourage the combinations this change permits. (src/outerloop/orchestrator.py:2268; high confidence)

Verdict: two non-blocking policy-alignment changes remain. Rejected: none; the coverage and prose reports are merged because they identify the same stale one-contribution rule in the research-line brief, with prose supplying the required replacement wording.

…othesis

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@renmengye

Copy link
Copy Markdown
Member Author

Both advisories batched in 86ca856: the research-line brief now says a PR to main is one idea with the few changes it needs, each change's effect in the report; generated PR bodies say one idea per PR. Pinned brief test updated.

@renmengye renmengye added the outerloop:review re-request the advisory review label Sep 26, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1 — reviewed head 86ca8562 — reviewer hermes/gpt-5.6-terra.

terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: no defects found.

@renmengye
renmengye merged commit 87d858c into main Sep 26, 2026
5 checks passed
@renmengye
renmengye deleted the docs/idea-not-knob branch September 26, 2026 21:48
@renmengye

Copy link
Copy Markdown
Member Author

Compatibility statement (added for the 0.3.0rc1 release audit, per RELEASING.md).

  • Surfaces: agent-visible instructions (the author brief and the panel rubric), PR-body wording, and a persisted finding category (landscape).
  • Oldest state read: v0.2.1 findings without the new category fall back to the existing categories.
  • First tick after upgrade (explicit tolerance, owner decision): judges start fresh sessions and use the new rubric immediately. A parked author resumes its existing conversation, which keeps the instructions it started with; the brief is not re-delivered. If the new rubric blocks such a run, the panel's feedback explains the rule and the author can revise. Runs started after the upgrade get the new brief.
  • Rollback: safe for records; findings in the new category are read as generic findings by older kernels.
  • Fixtures: a run parked under the v0.2.1 brief, resumed and judged with the current code, is added on the release branch for 0.3.0rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outerloop:review re-request the advisory review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant