Hermes as an author backend, with a bounded resume replay - #439
Merged
Merged
Conversation
Hermes was limited to judging because it could not resume a session; resume arrived later (saved-transcript rehydration) but the author allowlists were never updated. Hermes is now an author backend alongside Claude Code and Codex: init, attempt validation, tick preflight, author key selection, fresh and wake wiring, and the syscall path treat it as a peer. It always runs contained. Each wake starts a fresh Hermes invocation and replays the saved transcript, so a long-running author's prompt grew without bound. The replay now keeps the original brief and the latest results, fills the rest with the most recent turns within OUTERLOOP_HERMES_RESUME_MAX_CHARS (default 120000), and states how many turns were omitted; the saved transcript stays complete. If the brief and latest results alone exceed the budget, the run parks as blocked on configuration without consuming wake retries, and resumes once the budget is raised. Author and judge credentials are compared by resolved path and value, and init and preflight validate a Hermes author's model or endpoint, image and runtime. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Round 1 — reviewed head 20670590 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: 2 blocking, 1 advisory.
2 findings attached to the lines below.
Advisory (non-blocking):
- Do not validate the Hermes replay budget for non-Hermes setup. [deployment+general] This unconditional validation of OUTERLOOP_HERMES_RESUME_MAX_CHARS runs before the selected author is known, so a Claude or Codex deployment exits with status 2 when this Hermes-only setting is invalid even though no Hermes author resume can use it. (
src/outerloop/init.py:786; high confidence)
Merged three findings: two blocking defects in blocked-resume recovery and endpoint credential preflight, plus one advisory init-validation defect. Rejected findings: none; the deployment and general reports about Hermes replay validation were merged as the same finding.
…dential - The configuration-blocked marker is cleared when a resume succeeds or the run ends, so a later normal sleep is not re-woken. - Attempt and tick preflight share one helper for the author's effective credential, including endpoint profiles. - The Hermes replay budget is validated only when Hermes is the author. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hermes was limited to judging because it could not resume a session, and authors sleep and are woken with results. Resume arrived later (saved-transcript rehydration,
supports_resume = True), but the author allowlists ininit,attemptand the author config check were never updated, and the design doc still said Hermes could not resume.Changes
init(selection, runtime discovery, recorded paths), attempt validation, tick preflight, author key selection, fresh and wake wiring, and absolute syscall paths. Sleep/wake, submit, the depth loop, branches and commits already used shared paths. A Hermes author always runs contained.OUTERLOOP_HERMES_RESUME_MAX_CHARS(default 120000), and states how many turns were omitted. The saved transcript stays complete.initand preflight validate a Hermes author's model or endpoint profile, image, runtime, and the replay budget.Verified: full gate 2384 passed, 2 skipped; ruff, format, mypy clean. Cost reporting for Hermes stays zero because its trajectory carries no billing usage (documented).
🤖 Generated with Claude Code