Measurement provenance in PR bodies and judge briefs - #440
Merged
Merged
Conversation
…ges told to check commits before comparing numbers Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Round 1 — reviewed head 273031b3 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: 1 blocking, 0 advisory.
1 finding attached to the lines below.
One blocking finding: the stale-base checkpoint can record an unsubmitted sibling launch against candidate_sha, producing false PR provenance. Rejected findings: none; the remaining lenses reported no findings.
…eirs) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a judge evaluation, every configuration we tested misread one benchmark PR the same way: a reporting floor existed in older trees and was removed on main, and judges compared the author's older-tree experiment numbers with the orchestrator's current-tree measurement as if comparable. The PR body gave them no way to tell which tree each number came from.
This PR gives judges the evidence rather than a rule:
unknown.No change to how measurement works.
Compatibility (RELEASING.md)
The only persisted schema change is an optional
commitstring on submittedrows in
launches.jsonl, taken from the sealed tree passed to the launcher.History and experiment rendering tolerate all prior rows without that field,
including ended runs; these display unknown rather than guessing a commit.
Existing submission identities remain authoritative on retries.
On the first tick after upgrade, in-flight runs continue normally and existing
PR bodies remain unchanged. Newly created PR bodies include measurement and
launch provenance. No backfill or migration is required. Rolling back is safe:
older ledger readers ignore the additive field. Run records are unchanged.
tests/fixtures/launches-before-provenance.jsonlcaptures the prior submittedand ended row format; its test covers repeated reads, an idempotent re-park,
and retry after an interrupted append alongside new records.
Tests
PR body with provenance in Measured; experiments tables with and without recorded commits (legacy fixture); both briefs carry the caution. Mutation check: dropping the SHAs from Measured fails the provenance test. Gate: 2397 passed, 2 skipped; ruff check, ruff format --check, mypy clean.
Built by codex from my brief; codex gate plus my cross-review (all brief paths covered, ledger change additive, compatibility note moved from a new docs page into this PR body per RELEASING.md).
🤖 Generated with Claude Code