Author overrides: a list of slot-specific entries per target - #446
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Round 1 — reviewed head 8a2ed50b — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: no defects found.
No findings were submitted by any review lens. Rejected findings: none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OUTERLOOP_AUTHOR_OVERRIDESallowed one override per target, so two slots of the same target could not use different authors (for example one slot on Claude Code and another on Codex, both on a self-hosted model).A target may now map to a list of entries; each listed entry must name its
slots, and a slot may appear in only one entry. The single-object form is unchanged.select_overridepicks the entry whose slots include the agent; callers that check or install each backend iterate every entry.Compatibility (RELEASING.md)
Settings only; no persisted state changes. Existing single-object settings parse exactly as before.
Tests
List form parses and selects per slot; an empty list, a listed entry without slots, and a slot claimed twice are rejected with the setting-labelled error; existing tests unchanged. Gate: 2753 passed, 10 skipped; ruff, format, mypy clean.
🤖 Generated with Claude Code