A bad author override holds only its own slots; the tick keeps running - #450
Merged
Merged
Conversation
The tick no longer validates every override entry at startup and exits on the first bad one. Each claim checks its own slot: a bad entry holds fresh claims for its slots with one log line per tick, without falling back to the fleet author; an unparseable setting holds claims for the targets it names (or all), while sweeps, wakes and delivery continue. outerloop start and init still refuse a bad setting.
There was a problem hiding this comment.
Round 1 — reviewed head e2776094 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: no defects found.
No findings were reported by any review lens. Rejected findings: none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One bad
OUTERLOOP_AUTHOR_OVERRIDESentry (for example a codex entry whose bridge runtime is missing, or a model with no endpoint profile) made every tick exit at startup. The whole fleet then stopped: sweeps, wakes, message delivery, merges and the board for every target, not just the misconfigured slot.outerloop startandouterloop initstay strict, so an operator still sees the error when they change the setting.Compatibility: no persisted state changes (run records, inbox, ledger and caches are untouched), so no backfill or fixture is needed; rolling back restores the strict startup check.
Review: built by Codex; I reviewed it, checking every remaining reader of the setting (only the manual, unbound climb path reads it directly, and tick-launched jobs are always bound) and that a held slot never binds the fleet author. Gate: pytest, ruff check, ruff format --check, mypy.