Repository navigation
Contract: a conditional sibling-regression allowance per benchmark - #468
Merged
Merged
Conversation
An optional regression block lets a benchmark tolerate a free regression, cap it hard, and unlock the range in between only when the climbed benchmark improves by a required gain. One floor set both a benchmark's win bar and the regression it allowed on others, which could not express a memory benchmark that should climb at 5% yet allow a large speed win to cost some memory. Benchmarks without the block gate exactly as before; verdicts name the rule that decided.
There was a problem hiding this comment.
Round 1 — reviewed head 7489cf52 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: no defects found.
No findings were submitted by any review lens. Rejected findings: none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An optional per-benchmark
regressionblock. Today a benchmark's single floor sets both its win bar and the regression it tolerates as a sibling. The block separates the two:min_delta_rel/min_delta. An omitted free tolerance inherits the benchmark's floor, and the hard cap wins at equality.Motivating target: jepa.cpp, where a 27% GN-planner speedup cost 33% more memory, a trade the owner accepts. A single 5% memory floor would refuse it.
Verified
uv run pytest: 3,138 passed, 12 skipped. Ruff, mypy and gitleaks are clean.ps.contract_clivalidates a contract that uses the block.Review