🚸 51 - project id error#62
Conversation
| ); | ||
| }; | ||
|
|
||
| const WarningListItem = ({ fieldName }: { fieldName: string }) => ( |
There was a problem hiding this comment.
There is duplication of styling here between WarningListItem and ListItem
Might be worth creating one component for ListItem and then having a Missing type set of props.
Or even a MissingListItem component but use a common List component.
eg.
const MissingListItem = () => <ListItem fieldName=''..." value=''Missing" icon={<Warning/>}/>
|
|
||
| const [availableProjects, setAvailableProjects] = useState<Project[]>([]); | ||
| useEffect(() => { | ||
| fetch(`https://arranger.qa.overture.bio/admin/graphql`, { |
There was a problem hiding this comment.
url root best in an .env variable, make it easy to configure
There was a problem hiding this comment.
oh whoops i have this env var already, i forgot to use it!
| ); | ||
| }; | ||
|
|
||
| export default Error; |
There was a problem hiding this comment.
Just out of interest, how do you like doing icons like this? We do it this way on ARGO and it was a little annoying to start with
There was a problem hiding this comment.
I like it - I think because i got used to it on argo. It feels like dealing with icons is a lot more straightforward this way because they're just like any other component
|
@anncatton left some comments, let me know what you think |
Adds error messages for various configuration errors related to Arranger.
Adds styling and icons