💄 32 - UI feedback - #76
Merged
Merged
Conversation
joneubank
requested changes
Mar 12, 2021
| display: flex; | ||
| justify-content: space-between; | ||
| height: 50px; | ||
| height: ${NAVBAR_HEIGHT}px; |
| FACET_MIN_WIDTH, | ||
| FOOTER_HEIGHT, | ||
| NAVBAR_HEIGHT, | ||
| } from '../../../global/utils/constants'; |
There was a problem hiding this comment.
Is this an existing pattern or did you introduce this? These feel like values that usually get shared to CSS via the theme object.
| export const FACET_MAX_WIDTH = 270; | ||
| export const FACET_MIN_WIDTH = 250; | ||
| export const FOOTER_HEIGHT = 47; | ||
| export const NAVBAR_HEIGHT = 50; |
There was a problem hiding this comment.
Repeating comment about css properties belonging in theme.
joneubank
requested changes
Mar 15, 2021
joneubank
left a comment
There was a problem hiding this comment.
Thanks for updates. You can get rid of the consts now.
| export const FACET_MAX_WIDTH = 270; | ||
| export const FACET_MIN_WIDTH = 250; | ||
| export const FOOTER_HEIGHT = 47; | ||
| export const NAVBAR_HEIGHT = 50; |
Contributor
Author
There was a problem hiding this comment.
oh whoops i thought i did. derp
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all the issues in #32 , except showing only configured providers, that will be handled in a separate ticket.