Move API-exposed types into dpd-types-versions - #343
Open
taspelund wants to merge 1 commit into
Open
Conversation
taspelund
force-pushed
the
trey/dpd-api-escapes
branch
from
August 18, 2026 16:05
fce91ce to
87d342e
Compare
taspelund
requested review from
cfzimmerman,
internet-diglett,
nicolaskagami,
rcgoodfellow and
sunshowers
August 18, 2026 16:15
taspelund
force-pushed
the
trey/dpd-api-escapes
branch
from
August 18, 2026 17:25
87d342e to
7d542d5
Compare
sunshowers
reviewed
Aug 18, 2026
sunshowers
left a comment
Contributor
There was a problem hiding this comment.
Looks great, just a few comments.
Define the remaining API wire types in their introduction-version modules, and make dpd-types, common, and aal compatibility re-export layers. Keep runtime/controller types out of the API crate by converting transceiver values at the DPD boundary. Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
taspelund
force-pushed
the
trey/dpd-api-escapes
branch
from
August 18, 2026 18:28
7d542d5 to
679eab5
Compare
Contributor
Author
|
Thanks @sunshowers, all items addressed! |
sunshowers
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dpd-types,common, andaalcompatibility facades overdpd-types-versionsdpd-apiand convert transceiver-controller values at the DPD runtime boundaryThis is a refactor only; all blessed API documents remain unchanged.
Testing
cargo test -p dpd-types-versions -p dpd-apicargo clippy -p dpd-types-versions -p dpd-types -p dpd-api -p common -p aal --all-targetscargo clippy -p dpd --all-targets --features tofino_stubcargo run --package dendrite-dropshot-apis --bin dendrite-dropshot-apis -- check(all 12 documents fresh)