Typeahead component with tdd approch by RohitLuthra19 · Pull Request #185 · pagesource/atomic-react-components

RohitLuthra19 · 2019-12-14T19:45:32Z

No description provided.

accesslint

There are accessibility issues in these changes.

accesslint

There are accessibility issues in these changes.

accesslint

There are accessibility issues in these changes.

accesslint

There are accessibility issues in these changes.

accesslint

There are accessibility issues in these changes.

vinodloha

Small fixes required

accesslint

There are accessibility issues in these changes.

accesslint

There are accessibility issues in these changes.

… item of the list

accesslint

There are accessibility issues in these changes.

vinodloha · 2019-12-19T03:21:18Z

@RohitLuthra19 Please resolve conflicts.

Secondly, I think we are missing couple of use-cases.

When showing more than 5 or 10 (Configurable) items we should put a vertical scroll on list items.
How can we support no search results state?
First item should not be selected by default.

vinodloha

Tested the component, some more improvements required.

accesslint

There are accessibility issues in these changes.

accesslint

There are accessibility issues in these changes.

vinodloha · 2019-12-23T05:20:44Z

@RohitLuthra19 I tested your component with Voice Over and it could not read any of the search result items. Please test and fix.

accesslint

There are accessibility issues in these changes.

accesslint · 2019-12-23T07:12:11Z

+      ]
+    }
+    type="search"
+  />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

…ibility

accesslint

There are accessibility issues in these changes.

accesslint · 2019-12-23T08:30:11Z

+    onChange={[Function]}
+    onKeyDown={[Function]}
+    type="search"
+  />


Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

added typeahead component with tdd approch

c2296ec

accesslint Bot suggested changes Dec 14, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/tests/__snapshots__/Typeahead.test.js.snap

added aria-expanded

f473961

accesslint Bot suggested changes Dec 14, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

Rohit Luthra added 2 commits December 15, 2019 01:32

fixed linting error

d54e926

fixed linting error

64c9f2a

accesslint Bot suggested changes Dec 14, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

updated snapshots

f4ac3ff

accesslint Bot suggested changes Dec 15, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/tests/__snapshots__/Typeahead.test.js.snap

added feature to use customer filter method

f3b6f87

accesslint Bot suggested changes Dec 15, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/tests/__snapshots__/Typeahead.test.js.snap

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

updated test cases

471aadc

vinodloha reviewed Dec 15, 2019

View reviewed changes

Comment thread lib/components/atoms/Button/Button.js

vinodloha reviewed Dec 15, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/ListItem.js

vinodloha reviewed Dec 15, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

vinodloha reviewed Dec 15, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

vinodloha reviewed Dec 15, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

vinodloha reviewed Dec 15, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.story.js Outdated

vinodloha reviewed Dec 15, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/tests/Typeahead.test.js

vinodloha requested changes Dec 15, 2019

View reviewed changes

RohitLuthra19 changed the title ~~added typeahead component with tdd approch~~ Typeahead component with tdd approch Dec 16, 2019

implemented review comments

b507806

accesslint Bot suggested changes Dec 16, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

Vijendra Mishra and others added 7 commits December 16, 2019 16:27

updated code from develop

7d10452

updated snap shots

85bc143

updated snapshots

7091ffd

updated snap shots

246c3aa

implemented review comments

5e0be35

added jsx-a11y/label-has-associated-control

e7ffb74

removed jsx-a11y/label-has-associated-control

9956316

accesslint Bot suggested changes Dec 17, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

RohitLuthra19 and others added 3 commits December 17, 2019 18:26

Merge branch 'develop' into typeahead

ad86784

commented the test cases failing on travis

23b937f

fixed issue pressing down arrow key on last item should move to first…

5af0e75

… item of the list

accesslint Bot suggested changes Dec 17, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

vinodloha reviewed Dec 19, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

vinodloha requested changes Dec 19, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.story.js Outdated

Rohit Kumar and others added 3 commits December 19, 2019 12:08

merged changes

57b5469

implemented review comments

9689dd7

updated review comments

ef11282

accesslint Bot suggested changes Dec 21, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/Typeahead.js Outdated

Rohit Luthra added 3 commits December 22, 2019 00:40

fixed function typeof check

727bf91

removed default function props with null

e25a968

updated snapshots

d308c01

accesslint Bot suggested changes Dec 22, 2019

View reviewed changes

Comment thread lib/components/molecules/Typeahead/tests/__snapshots__/Typeahead.test.js.snap

Rohit Luthra added 2 commits December 22, 2019 15:27

updated snapshots

c061f6c

updated snapshots

6f5aa66

updated component to have accessibility support

950dd11

accesslint Bot suggested changes Dec 23, 2019

View reviewed changes

added typeahead entry in main export index.js file

47ea801

vinodloha approved these changes Dec 23, 2019

View reviewed changes

vinkumar2 and others added 2 commits December 23, 2019 12:53

Merge branch 'develop' into typeahead

dc44f19

updated typeahead component to support intial instructions for access…

cb84018

…ibility

accesslint Bot suggested changes Dec 23, 2019

View reviewed changes

vinodloha approved these changes Dec 23, 2019

View reviewed changes

vinodloha merged commit 6e99ef4 into develop Dec 23, 2019

vinodloha deleted the typeahead branch December 23, 2019 10:00

imsauravsingh mentioned this pull request Dec 27, 2019

fix(Typeahead Component): Searching pattern isn't working #204

Open

Conversation

RohitLuthra19 commented Dec 14, 2019

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinodloha left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vinodloha commented Dec 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vinodloha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vinodloha commented Dec 23, 2019

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint Bot Dec 23, 2019

Choose a reason for hiding this comment

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint Bot Dec 23, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

vinodloha commented Dec 19, 2019 •

edited

Loading