Skip to content

fix(log)!: Invalid* exceptions replaced with CommandError; errors are logged with the API response#137

Merged
palazzem merged 1 commit into
mainfrom
palazzem/issue-112
Feb 1, 2024
Merged

fix(log)!: Invalid* exceptions replaced with CommandError; errors are logged with the API response#137
palazzem merged 1 commit into
mainfrom
palazzem/issue-112

Conversation

@palazzem

@palazzem palazzem commented Feb 1, 2024

Copy link
Copy Markdown
Owner

Related Issues

Proposed Changes:

Instead of raising multiple exceptions and assuming what the error is, we raise a single CommandError exception when any command fails. Furthermore, we log the actual backend response, if any.

Testing:

n/a

Extra Notes (optional):

n/a

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7745958230

  • 0 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7745724435: 0.0%
Covered Lines: 374
Relevant Lines: 374

💛 - Coveralls

@palazzem
palazzem merged commit e283b2a into main Feb 1, 2024
@palazzem
palazzem deleted the palazzem/issue-112 branch February 1, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Error logs are not describing the real issue returned by the cloud API

2 participants