docs/contributing.md describes .github/workflows/test-flask.yaml, which was removed in 97b300c

[melbinjp]

docs/contributing.md (line 28) tells contributors:

• A CI workflow (.github/workflows/test-flask.yaml) runs Flask's test suite to catch downstream regressions.

That workflow no longer exists. It was removed in 97b300c ("add zizmor to scan workflows", 2026-04-03); the same commit modified lock.yaml, pre-commit.yaml, publish.yaml and tests.yaml and added zizmor.yaml, but test-flask.yaml was deleted rather than updated, and the commit message doesn't mention it. The current workflow set is lock, nightly, pre-commit, publish, tests, zizmor, and none of them run Flask's suite as far as I can see.

So the docs describe a downstream safety net that isn't running. Two different fixes depending on intent, which is why I'm asking rather than sending a patch:

• If dropping it was deliberate: happy to open a PR removing that bullet from docs/contributing.md.
• If it was collateral in the zizmor pass, then the Flask downstream regression check has been off since April and the docs are the only thing that noticed.

Found this with a tool I'm building that verifies documentation claims against the repository and its git history; the "documented file was deleted and never restored" check is what flagged it. Happy to send either patch, or neither if you'd rather handle it.

[davidism]

https://palletsprojects.com/contributing/llm-ai

[kdeldycke]

Ok that's clearly AI generated but still, what happened to our flask test workflow in #3304 ? @davidism was it deliberately removed?

I know the cases are clearly covered in unit tests for a while:

• click/tests/test_defaults.py

  Lines 347 to 352 in 8b44edf

  	def test_flask_debug_env_not_stomped_by_default_flag(runner, monkeypatch):
  	"""Eager callback must not overwrite env when the flag used its default.
  	Covers the Flask ``_set_debug`` pattern (pallets/flask#6025). Regression test
  	for https://github.com/pallets/click/issues/3458.
  	"""

• click/tests/test_options.py

  Lines 2569 to 2573 in 8b44edf

  	# default=None: 3-state pattern (e.g. Flask --reload/--no-reload).
  	# https://github.com/pallets/click/issues/3024
  	(None, [], None),
  	(None, ["--flag"], True),
  	(None, ["--no-flag"], False),

So if we want to reintroduce the Flask smoke test, we can add that to the list of nightly runs.

[davidism]

Yeah, that's why I left it open and just commented. I didn't remove it on purpose, probably got overwritten when I was copying configs around to the projects.

[kdeldycke]

Yeah, that's why I left it open and just commented. I didn't remove it on purpose, probably got overwritten when I was copying configs around to the projects.

It's OK, no worries, just added it back in #3768 .

[kdeldycke]

Yeah, that's why I left it open and just commented. I didn't remove it on purpose, probably got overwritten when I was copying configs around to the projects.

Merged upstream, and it's green: https://github.com/pallets/click/actions/runs/32000003432 ! :)