Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Transaction payment runtime apis: query call info and fee details - #1535

Merged
paritytech-processbot[bot] merged 2 commits into
masterfrom
muharem-transaction-payment-runtime-api-query-call-info-and-fee-detail
Aug 18, 2022
Merged

Transaction payment runtime apis: query call info and fee details#1535
paritytech-processbot[bot] merged 2 commits into
masterfrom
muharem-transaction-payment-runtime-api-query-call-info-and-fee-detail

Conversation

@muharem

@muharem muharem commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

Fixes paritytech/substrate#11665

New runtime api introduced in PR paritytech/substrate#11819

@paritytech-ci
paritytech-ci requested review from a team August 10, 2022 12:55
Comment thread Cargo.lock Outdated
[[package]]
name = "beefy-gadget"
version = "4.0.0-dev"
source = "git+https://github.com/paritytech/substrate?branch=master#fece0657f20e15df94be5833b164dfacd44823eb"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result of cargo update -p pallet-transaction-payment-rpc-runtime-api

@muharem muharem added A0-pleasereview C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 10, 2022
@muharem
muharem requested review from athei and bkchr August 10, 2022 12:57
@muharem muharem added C1-low 📌 and removed C1-low PR touches the given topic and has a low impact on builders. labels Aug 10, 2022
@paritytech-ci
paritytech-ci requested a review from a team August 11, 2022 15:39
@muharem
muharem requested review from dvdplm and kianenigma August 11, 2022 15:41
@muharem

muharem commented Aug 11, 2022

Copy link
Copy Markdown
Contributor Author

continuous-integration/gitlab-check-runtime check fail can be ignored, explained - https://github.com/paritytech/ci_cd/issues/538

@the-right-joyce the-right-joyce added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. and removed A0-pleasereview labels Aug 12, 2022
@athei athei added the T2-API This PR/Issue is related to APIs. label Aug 18, 2022

@ggwpez ggwpez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any RPC integration tests which query a node, maybe we should add that in the future.

@muharem

muharem commented Aug 18, 2022

Copy link
Copy Markdown
Contributor Author

bot merge

@paritytech-processbot
paritytech-processbot Bot merged commit 1680ae3 into master Aug 18, 2022
@paritytech-processbot
paritytech-processbot Bot deleted the muharem-transaction-payment-runtime-api-query-call-info-and-fee-detail branch August 18, 2022 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. T2-API This PR/Issue is related to APIs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make get_dispatch_info and weight_to_fee Available via state_call

6 participants