Conversation
Bumps the pinned toolchain to 1.98.0 (current stable) and VERSION to 0.18.5. Crates in the wild now declare rust-version above 1.93 (sysinfo requires 1.95 since 0.39.0), which makes 'cargo build --locked' fail during the srtool build before compiling anything. Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned toolchain from
1.93.0to1.98.0(latest stable) andVERSIONfrom0.18.4to0.18.5, following the same pattern as #99 and #95.Why
We're using
srtoolto create deterministic wasm runtimes for the Midnight node - we've pulled insysinfo@0.39.6which needs rustc 1.95, so we're getting compile errors:1.95 would be enough to unblock us, but I've gone to 1.98.0 since only the latest stable release of Rust receives patches.
Please let me know if I can make any further updates here - thanks!