Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Transfer gossiping messages from NetworkService straight to background tasks #6402

Description

@tomaka

At the moment, calling NetworkService::write_notifications synchronously verifies whether we have a connection with the peer, and if so sends a message on a channel in destination to the background task of this specific peer.

The problem is that this channel is already quite overloaded, and we should ideally try to reduce the traffic on this point of contention.
Additionally, we can't properly implement #5481 with this system.

Instead, there should be a field in NetworkService (not NetworkWorker) that directly contains channels whose receiving side are the background tasks.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions