Skip to content

Use libui's timer#104

Merged
parro-it merged 5 commits into
0_3_0from
uitimer
Jun 1, 2018
Merged

Use libui's timer#104
parro-it merged 5 commits into
0_3_0from
uitimer

Conversation

@parro-it

@parro-it parro-it commented May 3, 2018

Copy link
Copy Markdown
Owner

I recreated the PR because something get stuck on AppVeyor when I changed the base branch 😟
Closes #92
Closes #93

@parro-it

parro-it commented May 3, 2018

Copy link
Copy Markdown
Owner Author

I merged 0_3_0 branch, and add changes to include the hack to fix on Node 10.
But there is a problem with setTimeout. If you click the button on event-loop example two times in a second, clearTimeout is executed successfully and the running prop setted, but the callback is executed anyway when timeout expires.

@mischnic

mischnic commented May 3, 2018

Copy link
Copy Markdown
Collaborator

Could you try it again? I think the example wasn't quite right.

@parro-it

parro-it commented May 3, 2018

Copy link
Copy Markdown
Owner Author

Yes, you're right, it works now!

@parro-it

parro-it commented Jun 1, 2018

Copy link
Copy Markdown
Owner Author

This works well, going to merge in 0_3_0

@parro-it
parro-it merged commit 1c7266d into 0_3_0 Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants