Skip to content

Floorplan 'routing' export scope has no in-tree UI trigger #632

Description

@SomSamantray

Problem

The new 'routing' FloorplanExportScope (structure + utility, no furniture) is implemented and unit-tested, but the only in-tree callers of exportFloorplanPdf are the Settings-panel buttons hardcoding 'full' and 'structure'. In this repo 'routing' is reachable only by external host apps via the newly re-exported package API and by unit tests — no user can select it.

Suggested fix

Add a 'Routing (structure + utilities)' button in settings-panel/index.tsx alongside the existing two, calling exportFloorplanPdf('routing'); or, if the scope is host-only by design, surface it through an explicit host prop and document it.

Evidence

packages/editor/src/lib/floorplan/floorplan-export.tsx:73 -- export type FloorplanExportScope = 'full' | 'structure' | 'routing'
(settings-panel/index.tsx hardcodes 'full' at line 410 and 'structure' at line 418)

Source

Branch feat/floorplan-export-routing-scope (head f2d3051) — planned PR for #619.

Metadata

Severity: P3 | Confidence: 75 | Reviewer(s): adversarial, api-contract | Finding ID: floorplan-export-tsx-73-routing-unreachable

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions