Fail closed on missing furniture-fit inputs - #791
Merged
Merged
Conversation
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: a8f7c6fc-d82e-4e8c-abfa-ac8778f65b97 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The furniture-fit skill could answer a decisive missing measurement with speculative conditional thresholds. This release makes the input gate fail closed: it preserves supplied values, requests only the blocking input, permits a minimal read-only scene lookup only when that lookup can resolve the value from measured evidence, and blocks assessment or mutation until the input is resolved.
It also releases the skill as
furniture-fit0.1.2 in plugin bundle 0.1.3 and corrects the hosted Claude/Codex setup examples. Claude setup now guards an existingPASCAL_API_KEYinstead of assigning a placeholder; Codex guidance explicitly requires replacing the placeholder and documents that Codex stores the environment-variable name.Validation:
bun scripts/validate-skills.tsclaude plugin validate . --strictgit diff --check origin/main...HEADfurniture-fit/SKILL.mdSHA-256c5283ef5d593f7c8beb66d20d8131966305b24b27104398f42343498138a1bd4: 3/3 deterministic cases and 12/12 semantic criteria passed with no task retries. Both missing-input cases made zero Pascal MCP calls; the complete-input case used the real read-only candidate collision path and preserved graph hash, version, and export bytes.tools: [],mcpServers: [],plugins: [], and zero tool calls.The earlier invalid ambient-Codex judge receipt and the failed D02/submission cohorts remain unchanged. This PR does not claim automatic-routing promotion, official marketplace listing, external adoption, production hosted-session continuity, or support for height, door-swing, delivery-route, or detailed mesh checks.
Note
Low Risk
Changes are skill instructions, evals, version manifests, and setup documentation—no application runtime or auth server code.
Overview
furniture-fit now fails closed on decisive missing inputs: when width, depth, scale, pose, clearance, or similar is unresolved, agents must return
insufficient evidence, keep supplied facts, ask only for the blocking measurement, and not emit conditional max-fit sizes, hypothetical clearances, or run candidate/collision/placement/save tools. A minimal read-only scene lookup is allowed only to pull a value from measured evidence; candidate-call guidance is aligned with that gate.The release ships as plugin bundle 0.1.3 / furniture-fit 0.1.2 (manifests,
validate-skills.ts,VALIDATION.md), adds eval #8 for the missing-depth case, and tightens the insufficient-evidence example.Hosted setup docs (
furniture-fitandpascal-3dreferences/setup.md) now document saferPASCAL_API_KEYhandling: Claude uses a shell guard and--scope userwith an expanded Bearer header; Codex notes placeholder replacement and that only the env var name is stored.Reviewed by Cursor Bugbot for commit 6e6e5e8. Bugbot is set up for automated code reviews on this repo. Configure here.