fix(editor): respect export scope when collecting floorplan schedules - #857
Merged
Aymericr merged 1 commit intoSep 12, 2026
Merged
Conversation
collectFloorplanSchedules walked the whole level subtree and ignored FloorplanExportScope, so a structure-only PDF still emitted zone/room schedule pages whose geometry the same export excluded. Thread scope into the collector and gate schedule contributors with isFloorplanNodeInExportScope, matching geometry collection. Fixes pascalorg#631
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: a90203b7-ec2d-4fe5-a3be-8403524a093d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #631.
collectFloorplanScheduleswalked the entire level subtree and never tookFloorplanExportScopeinto account. A'structure'PDF still emitted zone/room schedule pages (and other non-structure contributors) whose plan geometry the same export excluded.exportFloorplanPdfalready passesscopeintocollectFloorplanGeometry. This threads the same scope into schedule collection and gates each schedule-contributing node kind withisFloorplanNodeInExportScope.How to test
structure.full— all schedules should still appear.collectFloorplanScheduleswith registered structure vs site kinds.Screenshots / screen recording
N/A — export content only.
Checklist
bun devbun checkto verify)mainbranchValidation
packages/editor:floorplan-export.test.ts25/25 pass (includes new scope test)@pascal-app/coreand@pascal-app/viewerbuilds cleanNote
Low Risk
Export-only behavior change with a default-preserving API and focused unit coverage; no auth or data-path changes.
Overview
Structure-scoped floorplan PDFs no longer include schedule pages for node kinds whose plan geometry is already excluded from that export (e.g. room/zone schedules when only structure is exported).
collectFloorplanSchedulesnow acceptsFloorplanExportScope(defaultfull) and skips schedule contributors that failisFloorplanNodeInExportScope, matchingcollectFloorplanGeometry.exportFloorplanPdfpasses the samescopeused for geometry into schedule collection.Adds a unit test that registers structure vs site schedule contributors and asserts
structureyields only structure schedules whilefullkeeps both.Reviewed by Cursor Bugbot for commit d530478. Bugbot is set up for automated code reviews on this repo. Configure here.