[chore] iOS 1.4 (build 10) - #274
Merged
Merged
Conversation
App Store Connect refuses a `CFBundleVersion` it has already seen, and 1.3 (9) is on TestFlight, so the tag `ios-release.yml` checks against has to move with it. Both targets carry the number and both move together; `Info.plist` is regenerated from `project.yml` rather than edited, since the next `xcodegen generate` would otherwise overwrite it. 1.4 rather than 1.3 (10) because what it carries is behavioural, not a rebuild: the microphone now survives the app leaving the foreground, one tap can no longer start two recordings, and recording begins on the tap instead of after the relay handshake (#272).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
iOS goes to 1.4 (build 10) in
ios/App/project.yml, withInfo.plistregenerated for both targets.Why
App Store Connect refuses a
CFBundleVersionit has already seen, and 1.3 (9) is already on TestFlight, so nothing can be uploaded until the number moves.ios-release.ymlalso refuses to build when the tag disagrees withCFBundleShortVersionString, so the tag and the plist have to move together.1.4 rather than 1.3 (10) because the build carries behaviour, not a rebuild — #272:
Info.plistis regenerated fromproject.ymlrather than hand-edited — the nextxcodegen generatewould overwrite an edit — and committed alongside, asios/RELEASING.mdasks.How it was verified
bunx tsc --noEmitpassesbunx vitest runpassesxcodegen generatereproduces exactly the two plists committed here; both targets report1.4/10.After merge
git tag ios-v1.4 && git push origin ios-v1.4to archive, export and upload to TestFlight. This will be the first run sinceAPPLE_IOS_DIST_P12was added — the previous fiveios-releaseruns all failed on the missing iOS Distribution certificate, and the fix has not yet been proven end to end.