[fix] the store packet stops contradicting itself, and the Play badge comes from the right source - #386
Merged
Conversation
Three claims outlived the thing they described. `data-safety.md` still answered Play's deletion question with "the honest answer today is request by other means", and its cross-check called deletion "the one real contradiction between the two stores". In-app account deletion has been there since #235, and per-recording deletion landed with 1.13 — which also clears what the phone kept locally: the audio saved for playback, a queued re-transcription, and the retry ledger entry. Android now goes further than iOS here, which is the opposite of what the file said. `review-notes.md` said the foreground-service demo video "still has to be hosted". `fgs-declaration.md` has recorded it as uploaded since 2026-08-19, with the URL. Two files in the same directory disagreeing about whether a submission blocker exists is worse than either answer. The warning that replaces it is the one that will actually be needed: that video shows meeting recording only, and Play reviews the declaration against the permission, so the release carrying voice typing needs a re-shoot. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The badge shipped as a PNG from `play.google.com/intl/en_us/badges/static/...`. That URL still serves, but the documented badges page now redirects to the Partner Marketing Hub, and the guidelines say to use the current assets from there. The lockup is visually identical, so nothing looked wrong — but the provenance was a stale copy rather than the source the rules point at, and a small multi-colour mark on a dark background at HiDPI is exactly where a downscaled bitmap shows its seams. The swap is not just a file change, and this is the part worth reading: the official SVG is edge-to-edge, while the legacy PNG carried 41px of transparent padding that was silently supplying 11.8px of the 12.1px of required clear space. Dropping the new file in without re-deriving the sizing would have shipped a badge with essentially no clear space — out of compliance, on a public page, looking fine. Height is now 48px with a 12px margin carrying the full quarter-height itself. Rendered size is unchanged at 162×48. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ SonarQube Quality Gate passed — pathorsAI_parley0 open issues on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things, one commit each.
The store packet contradicted itself
data-safety.mdstill answered Play's deletion question with "the honest answer today is request by other means", and its iOS cross-check called deletion "the one real contradiction between the two stores".In-app account deletion has been there since #235. Per-recording deletion landed with 1.13 — and it also clears what the phone kept locally: the audio saved for playback, a queued re-transcription, and the retry ledger entry. Android now goes further than iOS here, which is the opposite of what the file claimed.
review-notes.mdsaid the foreground-service demo video "still has to be hosted".fgs-declaration.md, in the same directory, has recorded it as uploaded since 2026-08-19 with the URL. Two files disagreeing about whether a submission blocker exists is worse than either answer being wrong.The warning that replaces it is the one that will actually be needed: that video shows meeting recording only, and Play reviews the declaration against the permission, so the release carrying voice typing needs a re-shoot.
The Play badge
It shipped as a PNG from
play.google.com/intl/en_us/badges/static/…. That URL still serves, but the documented badges page now redirects to the Partner Marketing Hub, and the guidelines say to use the current assets from there. The lockup is visually identical, so nothing looked wrong — but the provenance was a stale copy rather than the source the rules point at.The part worth reading: the official SVG is edge-to-edge, while the legacy PNG carried 41px of transparent padding that was silently supplying 11.8px of the 12.1px of required clear space. Dropping the new file in without re-deriving the sizing would have shipped a badge with essentially no clear space — out of compliance, on a public page, looking perfectly fine.
Height is now 48px with a 12px margin carrying the full quarter-height itself. Rendered size is unchanged at 162×48, so the layout is pixel-identical.
How it was verified
The SVG was checked for self-containment before use: no external references, no
<script>, text fully outlined. On the rendered page the badge loads and measures 162×48, the old PNG is gone from the tree, and no badge-related 404s appear in the console.tsc/vitestdo not cover this:tsconfig.jsonincludes onlysrc, andvitest.config.tsonlysrc/**andtests/**. Everything here is markdown, static HTML, CSS and an SVG.