[feature] updater: periodic re-check while the app stays open - #46
Merged
Merged
Conversation
…ays open The launch check only ran once, 3s after startup, so a long-running window never noticed a release that landed after open. Add a 30-min interval that re-runs the silent check; still surfaces only the dismissible banner, applying stays user-initiated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The in-app updater only checked once, 3 seconds after launch (src/App.tsx). A window left open for hours never noticed a release that shipped after startup.
This adds a slow recurring check on top of the launch check:
UpdateBanner; applying an update is still user-initiated, so it never interrupts a meeting30 min (not 1 min) because the check hits the GitHub releases endpoint — unauthenticated requests are rate-limited to 60/hour, and a tighter interval risks failed checks for no real benefit.
Test Coverage
No new code paths to unit-test meaningfully — the change is a
setIntervalinside an existinguseEffect, with the timer cleared on unmount. Existing suite covers the rest.Test plan
tsc --noEmitclean🤖 Generated with Claude Code