[chore] fix sonar S7741: compare globalThis.window with undefined directly - #6
Merged
Merged
Conversation
…ectly Follow-up to #5. `globalThis.window` is a property access that never throws, so the `typeof` guard it inherited from the bare `window` identifier is no longer needed.
✅ SonarQube Quality Gate passed — pathorsAI_pensieve0 open issues on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5, which left one new issue on the Quality Gate.
typeof window === "undefined"had to usetypeofbecause a barewindowidentifier throws aReferenceErrorwhen the global is absent.globalThis.windowis an ordinary property access that safely yieldsundefinedinstead, so the guard becomes a direct comparison.app/consent/consent-form.tsx:7—typeof globalThis.window === "undefined"→globalThis.window === undefinedbunx tsc --noEmitandbun run buildclean. This should take the Quality Gate onmainback to 0 open issues.