Skip to content

Wrong annotations for DenseInfos #399

Description

@Randl

DenseInfos are defined of shape times

DenseInfos = dict[str, PyTree[Shaped[Array, "times ..."]]]

While in fact it probably should be times+1:

assert _infos.shape[0] + 1 == self.ts.shape[0]

dense_ts = jnp.full(max_steps + 1, jnp.inf, dtype=time_dtype)
_make_full = lambda x: jnp.full(
(max_steps,) + jnp.shape(x), jnp.inf, dtype=x.dtype
)
dense_infos = jtu.tree_map(_make_full, dense_info)

As such global interpolation tests fail, e.g., see #391 but also locally on master

It is possibly related to some update, maybe of jaxtyping (this PR is on the new Lineax version).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions