Skip to content

Regression in v0.7.0 #607

Description

@terhorst

Updating to diffrax v0.7.0 suddenly made our models crash with the error message:

ValueError: A fixed step size controller is being used alongside an implicit solver, but the tolerances for the implicit solver have not been specified. (Being unspecified is the default in Diffrax.)

The code that causes the crash indeed uses diffrax.PIDController so the error seems wrong. Here is the snippet that leads to the error:

solver = dfx.Kvaerno3()
ssc = dfx.PIDController(jump_ts=jump_ts, rtol=1e-6, atol=1e-6)
res = dfx.diffeqsolve(
    term,
    solver,
    t0=t0,
    t1=t1,
    dt0=(t1 - t0) / 1000,
    args=args,
    y0=y0,
    stepsize_controller=ssc,
    max_steps=16384,
    saveat=saveat,
)

Downgrading to v0.6.2 fixes the problem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions