Resolves speed issue of #606. - #618
Conversation
|
Tagging @dkweiss31 -- I've taken a crack at an alternative to #614. It handles the adjoint issue you bumped into it by happening inside the inner @HeSchatz -- I've tested that this gives good performance on the microbenchmark of #606 (comment) Can you give this a go on your actual problem? |
|
I've tested with my actual problem and compile times are back down to ~1.5s with this commit. Great! In fact, it seems to be slightly faster now than with 0.6.0, most likely due to some other code improvements between 0.6.0 and now. Thank you both @patrick-kidger and @dkweiss31 for fixing this so fast! |
Fixes #606.
Supersedes #614.
The main part of this change is to use a dynamic-update-slice on the
t0==t1branch, rather than returning entirely new arrays. This is in-line with the way all of our other updates happen.Whilst I'm here I've also slightly refactored some other saving code.